Part of release 4.1.5
Thanks @ekes, this will be part of 4.1.5
Actually, #3 might work if we can fix the D11 deprecation of the loadRevision() call.
basvredeling → created an issue.
I've added a new quick demo video on the project page. See: https://www.youtube.com/watch?v=5aq-5XRtBMc
Marking this fixed. Still needs a release though. This commit mentioned in #4 will be part of the 4.1.5 release.
#17 looks good.
The patch #53 no longer seems to apply cleanly to config_split 2.0.2. Needs a re-roll.
patch looks good
Thanks for reporting @nelo_drup
Do you have any steps to reproduce?
Do you have revisioning enabled on the entity containing the paragraphs?
Do all paragraphs in the library still exist?
Hi @brooke_heaton,
deprecation is not necessarily a functional problem. So if you need to keep using the 3.x branch of paragraph_blocks on Drupal 10.3 you should not experience failures. However, if you're not tied to some ancient other module or wrote some custom implementation of 3.x I think you can safely upgrade to 4.x. The deprecation is fixed there.
So give you don't need anything of the below mentioned, do upgrade:
The 4.x branch will drop support for panels, geysir and support Drupal 10+ only.
Since I'm not investing more time into 3.x unless some major problem is uncovered there, I'm marking this as won't fix.
We need to record a new demo video. The original maintainer is not involved into this module any longer. And I believe the demo video was his. I'll remove the video from the module description/page for now. If anyone wants to record a quick demo video, be my guest.
If merged, this needs to be part of a new version of the fontawesome module as it will potentially break compatiblity with Drupal 10.2 and lower. I'd like to set the version to something higher than 8.x-2.x-dev but I can't.
Why would you try to fix that phpstan message from #23 now @elc? It's a Drupal 12 deprecation, so D11 compatibility is ensured, which is the goal of this issue.
Thanks @rakesh, this is now part of the 4.1.3 release.
@rakesh.gectcr please use the latest 4.x-dev to fix this issue. If that works well for you, I'll create a new release with this fix.
Thanks for reporting @rakesh.gectcr
The patch in #2 won't work I'm afraid. There is no \Drupal\paragraphs_plus\Entity\Paragraph class. I think checking for an instance of Drupal\paragraphs\Entity\Paragraph would be better.
basvredeling → created an issue.
This is trickier to implement than I initially anticipated due to this change: #2278541: Refactor block visibility to use condition plugins →
Part of release 4.1.2
Part of release 4.1.2
Part of release 4.1.2
Fixed deprecation warning in 86a541c2.
Please add this field type categories fix to the MR.
I believe MR 19 fixes all the paragraph library display issues. To test / review, please:
- define a paragraph type that has multiple display modes
- add a paragraphs field to a node type that uses above paragraph type
- configure the display mode of the node type to use layout builder and make sure the paragraph blocks of the new type are selectable
- enable the paragraph_library module
- set the paragraph type to be promotable to the library
- create a node with two paragraphs of the new type
- promote one of these paragraphs to the paragraph library
- edit the node's layout via the layout builder and check if you see a "Paragraphs" and a "Paragraphs from library" section
- check if both paragraphs have a selectable display mode and display properly both when they're just content on the node or content from the paragraph library
basvredeling → created an issue.
Reopened to check for more deprecations like this:
PHP Deprecated: Using a translatable string as a category for field type is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. See https://www.drupal.org/node/3375748
Rerolled patch for 10.3.x
src/Plugin/Field/FieldType/FontAwesomeIcon.php:17
causes a D11 deprecation warning:
Using a translatable string as a category for field type is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. See [#3375748]
It probably needs to refer to a new "icons" field type category supplied by fontawesome.field_type_categories.yml config.
@djanik Thanks for your patch. It is now part of 4.x-dev.
It looks like the change from this MR has been merged about a year ago. However, when installing latest 2.x-dev. I still get a .info.yml with a requirement on sdc:sdc instead of drupal:sdc.
Duplicate of 📌 CKEditor 5 compatibility Needs review
basvredeling → changed the visibility of the branch 3403721-layout-builder-changes to hidden.
Thanks for your contribution @stevenlafl @sarwan_verma
committed to 4.x-dev will be part of next release
From the top of my head, the SEO score calculation is performed only on the main body of a node and shown real time above that field. But it should be performed on fully rendered page display IMHO and that would require massive rework of the module. So no solution here.
Contributions appreciated
part of 2.0.0-alpha2
part of 2.0.0-alpha2
part of 2.0.0-alpha2
part of 2.0.0-alpha2
part of 2.0.0-alpha2
I think this needs to have a proper permission instead of a comment.
basvredeling → made their first commit to this issue’s fork.
This request is 4+ years old. I'm marking this outdated because with token support you can do quite a lot to improve admin titles. Feel free to reopen if you disagree or have some contribution that helps restart this issue.
We've introduced a middle ground with token support. See
✨
Enable tokens on admin title field
Fixed
If you want to make the experience less intrusive for editors you can opt to hide the field completely in the paragraph type's edit form configuration.
Thanks for all you input. This is out of scope for now. While I like the idea, there are no contributions to this feature request. And there are certain use cases which will make for a very complex UI. Marking as won't fix. Feel free to reopen if you can contribute a comprehensive patch or submodule to this effect.
Please also see my comments in https://www.drupal.org/project/paragraph_blocks/issues/3102777#comment-1... ✨ Ability to edit paragraph content directly from Layout Builder UI Active
Thanks for all your input. I tend to agree with @smustgrave in #8 that this will not work for complex paragraphs. I'd prefer to keep this out of the scope of the paragraph_blocks module. I'm closing this as won't fix. If someone supplies a submodule or comprehensive patch to supply this functionality, we might reopen this.
Part of release 4.1.1
thanks @tim_dj
basvredeling → created an issue.
@dalemoore if you have a contributed towards that effect, by all means submit your patches or MRs.
@viren18febS the change you've proposed has been included in a recent release 4.1.0. Hope that helps to alleviate the error itself reported in the issue description.
Marking this as outdated. Feel free to reopen if it needs additional work and you have code to contribute.
Fixed in releases 4.0.1 and 4.1.0
Fixed in releases 4.0.1 and 4.1.0
Fixed in releases 4.0.1 and 4.1.0
part of 4.1.0 release
basvredeling → created an issue.
Thanks for you input @chamilsanjeewa @Sweetchuck
I do not intend porting this to 3.x, changed version to 4.x-dev.
Thanks for your improvement. Merged to both 3.x and 4.x branches.
Now that SDC is part of core 📌 Move code from the experimental SDC module to core Fixed , perhaps the maintainers can give this patch another look.
Updating to e0ipso/twig-storybook:1.3.1 fixes it, it seems.
basvredeling → created an issue.
Part of release 4.0.0
Part of release 4.0.0
Thanks @tim_dj, these changes have all been merged. I'll make a new 4.x release soon.
@tim_dj I've changed the MR a bit and merged it into 4.x. Thanks.
I think we need 2 more things:
- A custom token that generates the paragraph summary as output. Just like is done inside the ParagraphBlocksLabeller:getTitle() when there is no admin title present. The \Drupal\paragraph_blocks\Entity\ParagraphBlocksEntity::getSummary() already does this, so that should be quite easy.
- Potentially, something like a drush command, to update all existing admin_titles, or just the ones that are empty, to a new tokenised structure.
basvredeling → made their first commit to this issue’s fork.
MR 26 solves the issue, but also feels like a patch on something that needs to be solved further upstream.