- Issue created by @basvredeling
- Status changed to Needs review
7 months ago 1:04pm 13 December 2023 - π³π±Netherlands basvredeling Amsterdam
This patch will break compatibility with fontawesome used in earlier Drupal versions prior to D10.1.0 (June 2023). Also the SDC module (experimental) needs to be enabled.
Besides the SDC component, this patch also includes a storybook *.stories.yml file. Please review and improve.
- π³π±Netherlands basvredeling Amsterdam
Example movie of fa icon preview in storybook β .
- e0ipso Can Picafort
+++ b/templates/fontawesomeicon.html.twig @@ -16,14 +16,15 @@ + tag: tag, + iconset: iconset, + name: name, + style: style, + settings: settings, + transforms: transforms, + mask: mask, + css: css,
You can simplify this with:
{ tag, iconset, name, style, settings, transforms, mask, css }
- π³π±Netherlands basvredeling Amsterdam
Updated patch with suggestion from #4
- π³π±Netherlands basvredeling Amsterdam
Now that SDC is part of core π± [META] Move code from the experimental SDC module to core Active , perhaps the maintainers can give this patch another look.