- Issue created by @basvredeling
- Status changed to Needs review
about 1 year ago 1:04pm 13 December 2023 - 🇳🇱Netherlands basvredeling Amsterdam
This patch will break compatibility with fontawesome used in earlier Drupal versions prior to D10.1.0 (June 2023). Also the SDC module (experimental) needs to be enabled.
Besides the SDC component, this patch also includes a storybook *.stories.yml file. Please review and improve.
- 🇳🇱Netherlands basvredeling Amsterdam
Example movie of fa icon preview in storybook → .
- e0ipso Can Picafort
+++ b/templates/fontawesomeicon.html.twig @@ -16,14 +16,15 @@ + tag: tag, + iconset: iconset, + name: name, + style: style, + settings: settings, + transforms: transforms, + mask: mask, + css: css,
You can simplify this with:
{ tag, iconset, name, style, settings, transforms, mask, css }
- 🇳🇱Netherlands basvredeling Amsterdam
Updated patch with suggestion from #4
- 🇳🇱Netherlands basvredeling Amsterdam
Now that SDC is part of core 📌 Move code from the experimental SDC module to core Fixed , perhaps the maintainers can give this patch another look.
- Status changed to RTBC
about 1 month ago 9:49am 2 December 2024 - 🇳🇱Netherlands tim_dj Netherlands
Works as advertised and patch looks good
- 🇳🇱Netherlands basvredeling Amsterdam
If merged, this needs to be part of a new version of the fontawesome module as it will potentially break compatiblity with Drupal 10.2 and lower. I'd like to set the version to something higher than 8.x-2.x-dev but I can't.