The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π©πͺGermany Anybody Porta Westfalica
@benjifisher sorry to ask this 3 years later, but do you know which patch was reviewed? #36?
If it's just these wording changes, I'd create a MR against 10.1.x and push things forward here.
Sad to see that https://www.drupal.org/project/media_private_access β has no Drupal 9/10 release, while this is still problematic. - First commit to issue fork.
- last update
over 1 year ago Custom Commands Failed - @grevil opened merge request.
- Status changed to Needs review
over 1 year ago 12:01pm 19 April 2023 - π©πͺGermany Grevil
I applied patch #36 manually on 10.1.x and changed the wording proposed in #38.
Please review!
- Status changed to Needs work
over 1 year ago 12:25pm 19 April 2023 - last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 12:38pm 19 April 2023 - Status changed to RTBC
over 1 year ago 1:10pm 19 April 2023 - π©πͺGermany Anybody Porta Westfalica
- Status changed to Needs work
over 1 year ago 1:15pm 19 April 2023 - πΊπΈUnited States phenaproxima Massachusetts
Looks like tests are failing on coding standards checks.
- π©πͺGermany Grevil
My apologies, my dev environment is not suited for core issue... Should definitly fix that!
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,291 pass, 2 fail - last update
about 1 year ago 29,676 pass, 2 fail