@xem8vfdh

thanks everyone for your work on this, very exciting :)

avoiding an unnecessary drupal module/module-fork would be good.

If this module shifts from depending on and installing the original Bootstrap JS package towards depending on and installing the fork linked above, I think this should be documented and explained with thorough detail on the module home page... why it is that we needed to fork, whose behind "enterprise7pro", etc.

I'm not fully following the discussion here, but if it is possible to make this module D11 compatible, that would be greatly appreciated. Migrating to Bootstrap 5 would be a momentous task.

thanks for review!

thanks for the info @jwineichen!

hopefully this module is still maintained and get a new (Drupal 11 supporting) stable release soon.

Looks like 11 just dropped, so a stable release would be nice :)

hey @salvis, I suppose it's that time again...

thank you everyone for working on this :)

Thanks @japerry! No issues thusfar in my testing. Will report back if I run into anything.

woah, big news @japerry! Thanks for the update and all of the hard work in recent days (and days to come), we sincerely appreciate it.

since the package is being used now, said fix should be available in the latest release/rc, which it isn't

https://www.drupal.org/project/panels/releases/8.x-4.8 →

https://www.drupal.org/project/panels/releases/8.x-4.8 →

xeM8VfDh → created an issue.

it's been quite a while. Are maintainers still monitoring? It sure would be nice to have a stable release :)

awesome, thanks!

amazing, thank you for the clarification, very much appreciated

https://www.drupal.org/project/panels/releases/8.x-4.8-rc1 →

https://www.drupal.org/project/panels/issues/2852655#comment-15583561 🌱 Plan for Panels 8.x-4.8 release Active

congrats, thanks you all for the work!

Do you know if composer handles `^4.8-rc1` gracefully, such that future 4.8 rcs and 4.8.1 or 4.9.0 would be accepted when available?

amazing, thanks!!

amazing, thanks @joseph.olstad!

Agreed

xeM8VfDh → created an issue.

I'd sure love to have this functionality back, so simple :(

THANKS @dqd!

It would be amazing if your team and other dedicated users could pick this up. Please keep us posted here and let us know how we can help.

If slack proves a dead end, consider contacting @gisle. He outlined the process to me here:

https://www.drupal.org/project/acl/issues/3348765 📌 New co-maintainer Closed: duplicate

this is a very old issue, so I'm guessing it's not a priority

but I'm wondering if instead of adding a warning we could store the password in some other way altogether (not plaintext)

I just installed version 8.x-1.2 on Drupal 10.2.1

I configured it and the test email worked, hooray!

But I do see this "Disabled fields are overridden in site-specific configuration file" message at the top of the config page and have no idea what it means or if I should ignore it.

hey @candelas, no luck here, unfortunately. I think this module is very minimally maintained.

Despite that, and despite my not knowing of any way to migrate Panels to Layout Builder, it does appear that the module is being minimally maintaned such that the minimum required changed have been made to allow it to keep working on Drupal 9, and now Drupal 10.

If you figure out how to do the migration, or otherwise have info to share on this, please post here!

awesome, thanks for all the work, i/we really appreciate it

following @larowlan's wise advice, I tested this commit (as a patch using cweagans/composer-patches) and my initial testing suggests that this patch does indeed fix my problem, after rolling back to 10.1.7 and rerunning the 10.2.0 upgrade. I will report back if I encounter any issues. Thank you all for fixing this!

@larowlan, I have tested that commit patch with cweagans/composer-patches and my tentative testing suggests it did indeed fix the problem! I will report this on the other issue as well.

Do you know how to do that? I use drupal/core-composer-scaffold, so I can't merely upgrade to a pinned commit (I don't think).

I do have cweagans/composer-patches, so I suppose I could turn the target commit into a patch that gets applied post composer update... is this the commit? https://git.drupalcode.org/project/drupal/-/commit/cb6d01843ebad4f86a0c3...

given the very bad nature of this bug, I think it should be added to the "Known Issues" section of the 10.2.0 release notes: https://www.drupal.org/project/drupal/releases/10.2.0 →

In fact, users should be advised to not upgrade to 10.2.0 and wait for 10.2.1

@larowlan thank you for pointing me to that other issue. It may indeed be the same issue I'm having. I commented there, linking back to my detailed comment here: https://www.drupal.org/project/drupal/issues/3410303#comment-15382742 🐛 FilterHtml data loss when iframe and/or textarea is allowed Active

I've been told me separate report may be an instance of this same issue. I've detailed my experience/symptoms here: https://www.drupal.org/project/drupal/issues/3412164#comment-15382735 🐛 upgrade from 10.1.7 to 10.2.0 removes HTML tags from many pages Postponed: needs info

The situation affecting my site as a result of upgrading from 10.1.7 to 10.2.0, which seems similar to this, is indeed critical. As outlined in my notes, the database appears uncorrupted by the upgrade, but the rendered output is corrupted, and once someone edits/saves a page, they persist the corruption to the database.

Sorry about the missing code wrapping.

I'm using CKEditor 5 both before and after the upgrade.

The content type I am using for this example uses the "Basic HTML" text format.

The associated configuration includes:

Enabled Filters:

• Limit allowed HTML tags and correct faulty HTML
• Align Images
• Caption Images
• Track Images Uploaded Via Text Editor
• Lazy Load Images
• Correct Fault and Chopped Off HTML
• Embed Media

Filter Processing Order:

1. Limit allowed HTML tags and correct faulty HTML
2. Align Images
3. Caption Images
4. Track images uploaded via text editor
5. Lazy load images
6. Correct faulty or chopped off HTML
7. Embed media

Limit Allowed HTML Tags And Correct Faulty HTML:

<br> <p class> <h1 class="text-align-left text-align-center text-align-right text-align-justify"> <h2 id class="text-align-left text-align-center text-align-right text-align-justify"> <h3 id class="text-align-left text-align-center text-align-right text-align-justify"> <h4 id class="text-align-left text-align-center text-align-right text-align-justify"> <h5 id class="text-align-left text-align-center text-align-right text-align-justify"> <h6 id class="text-align-left text-align-center text-align-right text-align-justify"> <ul class type> <div class id data-oembed-url> <img class src alt height width data-caption data-align data-entity-type data-entity-uuid> <table class cellpadding align> <cite> <footer> <dl> <dt> <dd> <oembed> <figure> <small> <span class> <iframe src scrolling type title bgcolor allowtransparency width height frameborder align> <figcaption class> <a hreflang target href aria-label title class id rel> <blockquote cite class> <ol type start> <hr class> <td padding class rowspan colspan> <drupal-media data-capture title data-entity-type data-entity-uuid alt data-caption data-align> <strong> <em> <code> <sub> <sup> <li> <tr> <th rowspan colspan> <thead> <tbody> <tfoot> <caption>

Composer Update Log

$ composer update 
Gathering patches for root package.
No patches supplied.
> DrupalComposerManaged\ComposerScripts::preUpdate
Loading composer repositories with package information
Updating dependencies
Lock file operations: 14 installs, 59 updates, 0 removals
  - Upgrading asm89/stack-cors (v2.1.1 => v2.2.0)
  - Upgrading behat/mink (v1.10.0 => v1.11.0)
  - Upgrading behat/mink-browserkit-driver (v2.1.0 => v2.2.0)
  - Upgrading behat/mink-selenium2-driver (v1.6.0 => v1.7.0)
  - Upgrading composer/ca-bundle (1.3.7 => 1.4.0)
  - Upgrading composer/composer (2.6.5 => 2.6.6)
  - Upgrading composer/semver (3.3.2 => 3.4.0)
  - Upgrading consolidation/annotated-command (4.9.1 => 4.9.2)
  - Upgrading drupal/core (10.1.7 => 10.2.0)
  - Upgrading drupal/core-composer-scaffold (10.1.7 => 10.2.0)
  - Upgrading drupal/core-dev (10.1.7 => 10.2.0)
  - Upgrading drupal/core-project-message (10.1.7 => 10.2.0)
  - Upgrading drupal/core-recommended (10.1.7 => 10.2.0)
  - Upgrading drupal/imce (3.0.10 => 3.0.11)
  - Locking google/protobuf (v3.25.1)
  - Upgrading guzzlehttp/guzzle (7.7.1 => 7.8.1)
  - Upgrading guzzlehttp/psr7 (2.5.1 => 2.6.2)
  - Upgrading instaclick/php-webdriver (1.4.16 => 1.4.18)
  - Upgrading mglaman/composer-drupal-lenient (1.0.3 => 1.0.4)
  - Locking micheh/phpcs-gitlab (1.1.0)
  - Upgrading nikic/php-parser (v4.17.1 => v4.18.0)
  - Locking open-telemetry/api (1.0.1)
  - Locking open-telemetry/context (1.0.0)
  - Locking open-telemetry/exporter-otlp (1.0.1)
  - Locking open-telemetry/gen-otlp-protobuf (1.0.0)
  - Locking open-telemetry/sdk (1.0.4)
  - Locking open-telemetry/sem-conv (1.23.1)
  - Locking php-http/discovery (1.19.2)
  - Locking php-http/guzzle7-adapter (1.0.0)
  - Locking php-http/httplug (2.4.0)
  - Locking php-http/promise (1.2.1)
  - Upgrading phpspec/prophecy (v1.17.0 => v1.18.0)
  - Upgrading phpspec/prophecy-phpunit (v2.0.2 => v2.1.0)
  - Upgrading phpstan/phpdoc-parser (1.24.4 => 1.24.5)
  - Upgrading phpstan/phpstan (1.10.47 => 1.10.50)
  - Upgrading phpunit/php-code-coverage (9.2.29 => 9.2.30)
  - Upgrading psy/psysh (v0.11.22 => v0.12.0)
  - Upgrading sebastian/complexity (2.0.2 => 2.0.3)
  - Upgrading sebastian/lines-of-code (1.0.3 => 1.0.4)
  - Upgrading seld/jsonlint (1.10.0 => 1.10.1)
  - Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.0)
  - Upgrading symfony/console (v6.3.9 => v6.4.2)
  - Upgrading symfony/dependency-injection (v6.3.10 => v6.4.2)
  - Upgrading symfony/deprecation-contracts (v3.3.0 => v3.4.0)
  - Upgrading symfony/error-handler (v6.3.5 => v6.4.0)
  - Upgrading symfony/event-dispatcher (v6.3.2 => v6.4.2)
  - Upgrading symfony/event-dispatcher-contracts (v3.3.0 => v3.4.0)
  - Upgrading symfony/http-foundation (v6.3.9 => v6.4.2)
  - Upgrading symfony/http-kernel (v6.3.10 => v6.4.2)
  - Upgrading symfony/lock (v6.4.0 => v6.4.2)
  - Locking symfony/mailer (v6.4.2)
  - Upgrading symfony/mime (v6.3.5 => v6.4.0)
  - Upgrading symfony/phpunit-bridge (v6.4.1 => v6.4.2)
  - Upgrading symfony/polyfill-ctype (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-iconv (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-intl-grapheme (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-intl-idn (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-intl-normalizer (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-mbstring (v1.27.0 => v1.28.0)
  - Locking symfony/polyfill-php82 (v1.28.0)
  - Upgrading symfony/polyfill-php83 (v1.27.0 => v1.28.0)
  - Upgrading symfony/process (v6.3.4 => v6.4.2)
  - Upgrading symfony/psr-http-message-bridge (v2.2.0 => v6.4.2)
  - Upgrading symfony/routing (v6.3.10 => v6.4.2)
  - Upgrading symfony/serializer (v6.3.10 => v6.4.2)
  - Upgrading symfony/service-contracts (v3.3.0 => v3.4.1)
  - Upgrading symfony/string (v6.3.9 => v6.4.2)
  - Upgrading symfony/translation-contracts (v3.3.0 => v3.4.1)
  - Upgrading symfony/validator (v6.3.9 => v6.4.2)
  - Upgrading symfony/var-dumper (v6.3.8 => v6.4.2)
  - Upgrading symfony/var-exporter (v6.3.10 => v6.4.2)
  - Upgrading symfony/yaml (v6.3.8 => v6.4.0)
  - Upgrading twig/twig (v3.6.1 => v3.8.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 14 installs, 59 updates, 0 removals
Gathering patches for root package.
No patches supplied.
Gathering patches for dependencies. This might take a minute.
  - Upgrading drupal/core-composer-scaffold (10.1.7 => 10.2.0): Extracting archive
php-http/discovery contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "php-http/discovery" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?] y
  - Installing php-http/discovery (1.19.2): Extracting archive
  - Upgrading drupal/core-project-message (10.1.7 => 10.2.0): Extracting archive
  - Upgrading mglaman/composer-drupal-lenient (1.0.3 => 1.0.4): Extracting archive
  - Upgrading composer/ca-bundle (1.3.7 => 1.4.0): Extracting archive
  - Upgrading symfony/polyfill-mbstring (v1.27.0 => v1.28.0): Extracting archive
  - Upgrading symfony/polyfill-intl-normalizer (v1.27.0 => v1.28.0): Extracting archive
  - Upgrading symfony/polyfill-intl-grapheme (v1.27.0 => v1.28.0): Extracting archive
  - Upgrading symfony/polyfill-ctype (v1.27.0 => v1.28.0): Extracting archive
  - Upgrading symfony/string (v6.3.9 => v6.4.2): Extracting archive
  - Upgrading symfony/service-contracts (v3.3.0 => v3.4.1): Extracting archive
  - Upgrading symfony/deprecation-contracts (v3.3.0 => v3.4.0): Extracting archive
  - Upgrading symfony/console (v6.3.9 => v6.4.2): Extracting archive
  - Upgrading composer/semver (3.3.2 => 3.4.0): Extracting archive
  - Upgrading twig/twig (v3.6.1 => v3.8.0): Extracting archive
  - Upgrading symfony/yaml (v6.3.8 => v6.4.0): Extracting archive
  - Upgrading symfony/translation-contracts (v3.3.0 => v3.4.1): Extracting archive
  - Upgrading symfony/polyfill-php83 (v1.27.0 => v1.28.0): Extracting archive
  - Upgrading symfony/validator (v6.3.9 => v6.4.2): Extracting archive
  - Upgrading symfony/serializer (v6.3.10 => v6.4.2): Extracting archive
  - Upgrading symfony/routing (v6.3.10 => v6.4.2): Extracting archive
  - Upgrading symfony/http-foundation (v6.3.9 => v6.4.2): Extracting archive
  - Upgrading symfony/psr-http-message-bridge (v2.2.0 => v6.4.2): Extracting archive
  - Upgrading symfony/process (v6.3.4 => v6.4.2): Extracting archive
  - Upgrading symfony/polyfill-iconv (v1.27.0 => v1.28.0): Extracting archive
  - Upgrading symfony/polyfill-intl-idn (v1.27.0 => v1.28.0): Extracting archive
  - Upgrading symfony/mime (v6.3.5 => v6.4.0): Extracting archive
  - Upgrading symfony/event-dispatcher-contracts (v3.3.0 => v3.4.0): Extracting archive
  - Upgrading symfony/event-dispatcher (v6.3.2 => v6.4.2): Extracting archive
  - Installing symfony/mailer (v6.4.2): Extracting archive
  - Upgrading symfony/var-dumper (v6.3.8 => v6.4.2): Extracting archive
  - Upgrading symfony/error-handler (v6.3.5 => v6.4.0): Extracting archive
  - Upgrading symfony/http-kernel (v6.3.10 => v6.4.2): Extracting archive
  - Upgrading symfony/var-exporter (v6.3.10 => v6.4.2): Extracting archive
  - Upgrading symfony/dependency-injection (v6.3.10 => v6.4.2): Extracting archive
  - Upgrading guzzlehttp/psr7 (2.5.1 => 2.6.2): Extracting archive
  - Upgrading guzzlehttp/guzzle (7.7.1 => 7.8.1): Extracting archive
  - Upgrading asm89/stack-cors (v2.1.1 => v2.2.0): Extracting archive
  - Upgrading drupal/core (10.1.7 => 10.2.0): Extracting archive
  - Upgrading symfony/phpunit-bridge (v6.4.1 => v6.4.2): Extracting archive
  - Upgrading symfony/lock (v6.4.0 => v6.4.2): Extracting archive
  - Upgrading nikic/php-parser (v4.17.1 => v4.18.0): Extracting archive
  - Upgrading sebastian/lines-of-code (1.0.3 => 1.0.4): Extracting archive
  - Upgrading sebastian/complexity (2.0.2 => 2.0.3): Extracting archive
  - Upgrading phpunit/php-code-coverage (9.2.29 => 9.2.30): Extracting archive
  - Upgrading phpstan/phpstan (1.10.47 => 1.10.50): Extracting archive
  - Upgrading phpstan/phpdoc-parser (1.24.4 => 1.24.5): Extracting archive
  - Upgrading phpspec/prophecy (v1.17.0 => v1.18.0): Extracting archive
  - Upgrading phpspec/prophecy-phpunit (v2.0.2 => v2.1.0): Extracting archive
  - Installing php-http/promise (1.2.1): Extracting archive
  - Installing php-http/httplug (2.4.0): Extracting archive
  - Installing php-http/guzzle7-adapter (1.0.0): Extracting archive
  - Installing symfony/polyfill-php82 (v1.28.0): Extracting archive
  - Installing open-telemetry/sem-conv (1.23.1): Extracting archive
  - Installing open-telemetry/context (1.0.0): Extracting archive
  - Installing open-telemetry/api (1.0.1): Extracting archive
  - Installing open-telemetry/sdk (1.0.4): Extracting archive
  - Installing google/protobuf (v3.25.1): Extracting archive
  - Installing open-telemetry/gen-otlp-protobuf (1.0.0): Extracting archive
  - Installing open-telemetry/exporter-otlp (1.0.1): Extracting archive
  - Installing micheh/phpcs-gitlab (1.1.0): Extracting archive
  - Upgrading instaclick/php-webdriver (1.4.16 => 1.4.18): Extracting archive
  - Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.0): Extracting archive
  - Upgrading seld/jsonlint (1.10.0 => 1.10.1): Extracting archive
  - Upgrading composer/composer (2.6.5 => 2.6.6): Extracting archive
  - Upgrading behat/mink (v1.10.0 => v1.11.0): Extracting archive
  - Upgrading behat/mink-selenium2-driver (v1.6.0 => v1.7.0): Extracting archive
  - Upgrading behat/mink-browserkit-driver (v2.1.0 => v2.2.0): Extracting archive
  - Upgrading drupal/core-dev (10.1.7 => 10.2.0)
  - Upgrading drupal/core-recommended (10.1.7 => 10.2.0)
  - Upgrading drupal/imce (3.0.10 => 3.0.11): Extracting archive
  - Upgrading psy/psysh (v0.11.22 => v0.12.0): Extracting archive
  - Upgrading consolidation/annotated-command (4.9.1 => 4.9.2): Extracting archive
3 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
96 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
PHP CodeSniffer Config installed_paths set to ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard
phpstan/extension-installer: Extensions installed
> composer/composer: installed
> mglaman/phpstan-drupal: installed
> phpstan/phpstan-deprecation-rules: installed
> phpstan/phpstan-phpunit: installed
Scaffolding files for drupal/core:
  - Skip [project-root]/.editorconfig: overridden in pantheon-upstreams/drupal-composer-managed
  - Skip [project-root]/.gitattributes: overridden in pantheon-upstreams/drupal-composer-managed
  - Copy [web-root]/INSTALL.txt from assets/scaffold/files/drupal.INSTALL.txt
  - Copy [web-root]/robots.txt from assets/scaffold/files/robots.txt
  - Copy [web-root]/sites/example.settings.local.php from assets/scaffold/files/example.settings.local.php
  - Copy [web-root]/sites/default/default.services.yml from assets/scaffold/files/default.services.yml
  - Copy [web-root]/sites/default/default.settings.php from assets/scaffold/files/default.settings.php
Scaffolding files for pantheon-systems/drupal-integrations:
  - Skip [web-root]/sites/default/settings.php because it already exists and overwrite is false.
> DrupalComposerManaged\ComposerScripts::postUpdate
No security vulnerability advisories found

updatedb Log

 ------------ ------------------- --------------- ----------------------------- 
  Module       Update ID           Type            Description                  
 ------------ ------------------- --------------- ----------------------------- 
  system       10101               hook_update_n   10101 - Change the {batch} table [bid] field to serial.                      
  system       10201               hook_update_n   10201 - Clear left over entries in the revision data table.                  
  help         10200               hook_update_n   10200 - Install search index table for help topics.                      
  ckeditor5    list_multiblock     post-update     Updates Text Editors using CKEditor 5.                  
  ckeditor5    list_start_reversed   post-update     Updates Text Editors using CKEditor 5 to native List "start" functionality.       
  file         add_default_filename_sanitization_configuration   post-update     Add default filename sanitization configuration.                                                    
  filter       sort_filters        post-update     Sorts filter format filter configuration.               
  help         add_permissions_to_roles   post-update     Grant all admin roles the 'access help pages' permission.                  
  help         help_topics_search   post-update     Install or update config for help topics if the search module installed.     
  help         help_topics_uninstall   post-update     Uninstall the help_topics module if installed.         
  media        set_blank_iframe_domain_to_null   post-update     Updates media.settings:iframe_domain config if it's still at the default.                 
  path_alias   drop_path_alias_status_index   post-update     Remove the path_alias__status index.    
  system       add_description_to_entity_form_mode   post-update     Update description for form modes.                       
  system       add_description_to_entity_view_mode   post-update     Update description for view modes.                                                         
  system       mailer_dsn_settings   post-update     Add new default mail transport dsn.               
  system       mailer_structured_dsn_settings   post-update     Add new default mail transport dsn.               
  system       remove_asset_entries   post-update     Remove redundant asset state and config.            
  system       remove_asset_query_string   post-update     Remove redundant asset query string state.          
  system       set_blank_log_url_to_null   post-update     Updates system.theme.global:logo.url config if it's still at the default.                 
  update       set_blank_fetch_url_to_null   post-update     Updates update.settings:fetch.url config if it's still at the default.                     
  views        add_missing_labels   post-update     Add labels to views which don't have one.              
  views        remove_default_argument_skip_url   post-update     Remove default_argument_skip_url setting.                     
  views        remove_skip_cache_setting   post-update     Remove the skip_cache settings.                    
  views        taxonomy_filter_user_context   post-update     Removes User context from views with taxonomy filters.                     
 ------------ ------------------- --------------- ----------------------------- 


 Do you wish to run the specified pending updates? (yes/no) [yes]:
 > yes

>  [notice] Update started: system_update_10101
>  [notice] Update completed: system_update_10101
>  [notice] Update started: system_update_10201
>  [notice] Update completed: system_update_10201
>  [notice] Update started: help_update_10200
>  [notice] Update completed: help_update_10200
>  [notice] Update started: ckeditor5_post_update_list_multiblock
>  [notice] Update completed: ckeditor5_post_update_list_multiblock
>  [notice] Update started: ckeditor5_post_update_list_start_reversed
>  [notice] Update completed: ckeditor5_post_update_list_start_reversed
>  [notice] Update started: file_post_update_add_default_filename_sanitization_configuration
>  [notice] Update completed: file_post_update_add_default_filename_sanitization_configuration
>  [notice] Update started: filter_post_update_sort_filters
>  [notice] Update completed: filter_post_update_sort_filters
>  [notice] Update started: help_post_update_add_permissions_to_roles
>  [notice] Update completed: help_post_update_add_permissions_to_roles
>  [notice] Update started: help_post_update_help_topics_search
>  [notice] Update completed: help_post_update_help_topics_search
>  [notice] Update started: help_post_update_help_topics_uninstall
>  [notice] Update completed: help_post_update_help_topics_uninstall
>  [notice] Update started: media_post_update_set_blank_iframe_domain_to_null
>  [notice] Update completed: media_post_update_set_blank_iframe_domain_to_null
>  [notice] Update started: path_alias_post_update_drop_path_alias_status_index
>  [notice] Update completed: path_alias_post_update_drop_path_alias_status_index
>  [notice] Update started: system_post_update_add_description_to_entity_form_mode
>  [notice] Update completed: system_post_update_add_description_to_entity_form_mode
>  [notice] Update started: system_post_update_add_description_to_entity_view_mode
>  [notice] Update completed: system_post_update_add_description_to_entity_view_mode
>  [notice] Update started: system_post_update_mailer_dsn_settings
>  [notice] Update completed: system_post_update_mailer_dsn_settings
>  [notice] Update started: system_post_update_mailer_structured_dsn_settings
>  [notice] Update completed: system_post_update_mailer_structured_dsn_settings
>  [notice] Update started: system_post_update_remove_asset_entries
>  [notice] Update completed: system_post_update_remove_asset_entries
>  [notice] Update started: system_post_update_remove_asset_query_string
>  [notice] Update completed: system_post_update_remove_asset_query_string
>  [notice] Update started: system_post_update_set_blank_log_url_to_null
>  [notice] Update completed: system_post_update_set_blank_log_url_to_null
>  [notice] Update started: update_post_update_set_blank_fetch_url_to_null
>  [notice] Update completed: update_post_update_set_blank_fetch_url_to_null
>  [notice] Update started: views_post_update_add_missing_labels
>  [notice] Update completed: views_post_update_add_missing_labels
>  [notice] Update started: views_post_update_remove_default_argument_skip_url
>  [notice] Update completed: views_post_update_remove_default_argument_skip_url
>  [notice] Update started: views_post_update_remove_skip_cache_setting
>  [notice] Update completed: views_post_update_remove_skip_cache_setting
>  [notice] Update started: views_post_update_taxonomy_filter_user_context
>  [notice] Update completed: views_post_update_taxonomy_filter_user_context
 [success] Finished performing updates.

Analysis

The editor config appears untouched by the upgrade. All of the settings are the same before and after the upgrade.

Before the upgrade, I had a page with a block of HTML appearing in the top level of the Editor--Source pane, which I tracked through various stages pre and post-upgrade. Below are my findings.

Before Upgrade

In Database

<div class="col-md-6">
   <figure>
      <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%">
      <figcaption><em>EXAMPLE CAPTION TEXT.</em></figcaption>
   </figure>
</div>

On Rendered Page

<div class="col-md-6">
   <figure>
      <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%">
      <figcaption><em>EXAMPLE CAPTION TEXT.</em></figcaption>
   </figure>
</div>

From Editor--Source

<div class="col-md-6">
   <figure>
      <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%">
      <figcaption>
         <em>EXAMPLE CAPTION TEXT.</em>
      </figcaption>
   </figure>
</div>

After Upgrade

In Database

<div class="col-md-6">
   <figure>
      <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%">
      <figcaption><em>EXAMPLE CAPTION TEXT.</em></figcaption>
   </figure>
</div>

On Rendered Page

This is where the breaking starts, note the missing <figcaption> and <em> tags.

<div class="col-md-6">
   <figure><img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%">EXAMPLE CAPTION TEXT.</figure>
</div>

From Editor--Source

The system has replaced my <figcaption> tag with a <p> tag. The <em> is preserved here.

<div class="col-md-6">
    <figure>
        <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%" height="100%">
        <p>
            <em>EXAMPLE CAPTION TEXT.</em>
        </p>
    </figure>
</div>

After Upgrade, Edit, Save (no changes)

In Database

The bad tag transformation is persisted to the database :(

<div class="col-md-6">
   <figure>
      <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%" height="100%">
      <p><em>EXAMPLE CAPTION TEXT.</em></p>
   </figure>
</div>

On Rendered Page

The <em> is missing now...

<div class="col-md-6">
   <figure>
      <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%" height="100%" loading="lazy">
      <p>EXAMPLE CAPTION TEXT.</p>
   </figure>
</div>

From Editor--Source

<div class="col-md-6">
    <figure>
        <img src="/sites/default/files/assets/example.jpg" alt="EXAMPLE CAPTION TEXT" width="100%" height="100%">
        <p>
            <em>EXAMPLE CAPTION TEXT.</em>
        </p>
    </figure>
</div>

xeM8VfDh → created an issue.

@NikLP can you link to the IMCE issue?

i updated from 10.1.7 to 10.2.0 and, without editing any pages, a lot of my pages' html is broken, with

Luke.Leber → credited xeM8VfDh → .

FWIW, I am using it in D10 with latest 2.x release of ACL without issue

Thanks @joseph.olstad. Is there documentation somewhere for how I can setup a testing environment to duplicate these failures? If I can get that set up I can do my best to take a look at resolving them.

@joelpittet, any progress on the failing IPE test? If not, can you point me to the test runner failure and I can try to take a look?

thanks everyone! This does seem like something truly out of our hands thats full of confusing and misleading variables :)

Anywho, your alls analysis sounds right and reasonable to me.

THANKS for the 2.x beta @salvis, this is great!

sorry, I suppose I misunderstood the versioning bit.

@pfrenssen mentioned needing to get to Drupal 10.0.10. Are you saying D10.0.7 is "latest stable" and "10.0.10" is not eligible to be used? I have no idea how to find "stable release" information. All I see is this comprehensive list: https://www.drupal.org/project/drupal/releases →

in any regard, it sounds like you are saying "ignore the failing PHP8.3 test runners for now". so lets ignore that.

The main topic of this issue still remains, however... or does it? I ask because you said "we should be set as far as the testbot goes".

So I am still just generally confused.

It would be helpful to me if you can provide the following information:

1. is this issue (regarding failing dep tests) a "problem"? (yes/no)
2. if yes, are you clear about how to resolve the issue? (yes/no)
3. are there other issues blocking us from tagging a 2.x release? (if yes, a simple bulleted list of those tasks would be nice)

thanks :)

hey @pfrenssen, thanks again for the thorough insight here.

you said "there is nothing we can do" but then you said we need to "change our automated test configuration".

You reasoning for updating the testing config sounds spot on to me. It sounds to me like the explicit step forward is the following, but please correct me if I am wrong:

@salvis need to update the 2.x-dev automated testing configuration → to change the following 3 (of 5) runners from :

PHP 8.1 & MySQL 5.7 updated deps, D10.0.7 2
PHP 8.2 & MySQL 8, D10.0.7
PHP 8.2 & sqlite-3.34, D10.0.7

to

PHP 8.1 & MySQL 5.7 updated deps, D10.1
PHP 8.2 & MySQL 8, D10.1
PHP 8.2 & sqlite-3.34, D10.1

The other two runners, which use PHP8.3 are failing on composer commands. I think that problem is unrelated to this issue. I am not sure if I should open a seperate issue for that problem, and both need to be resolved before a new 2.x alpha/beta/rc release, or if this is the only blocker at the moment. If you know the answer, by all means let me know, otherwise it may be a decision for @salvis.

that's an interesting point.

ideally, it would be nice if the symfony dependency depended on the target druapl version. in fact, I thought this was kind of how composer worked naturally, but I might not be fully grasping the problem space here.

SUPER helpful @pfrenssen, thank you!

@salvis, I think you are the only one with permissions to update/fix the test runner environments. If I can help in some way, please let me know.

@salvis, if you can fix this (or instruct me how to reproduce it so that I can submit a patch), can we then release a proper beta release of the 2.x branch? Or are there other outstanding issues? If so, we should probably open a separate "2.x beta release" issue where we track all the blockers.

Thanks @pfrenssen for the clarification! I opened a new issue: https://www.drupal.org/project/acl/issues/3389630 🐛 [2.x] Failing updated deps test Fixed

xeM8VfDh → created an issue.

hey @salvis. I still do not see the 2.x release on the ACL module home page. Likewise, I see no beta release.

As for the errors in the test, it may be an issue with the test environment. a cursory glance makes it seem to me like the version of Drupal and the version of Symfony are not compatible. I'd be happy to look further into this if you can assist me in setting up a test environment to duplicate the errors. Drupal being what it is, I cannot simply clone the 2.x branch locally and run tests. Or perhaps there some official documentation somewhere you can point me to... it's been a while since I've done this process locally.

thanks @Rajab Natshah, I'm hoping for a release too :)

I see 2.x on the releases page, as referenced by @salvis: https://www.drupal.org/project/acl/releases →

but yes, I agree that following the steps provided in #99 would be nice. beyond simply showing the 2.x dev branch, it would also be nice to have an alpha/beta/rc release for 2.x to avoid pulling from dev-master or pinning to a specific commit.

@gisle, where did you find the

unpublished version 2.x-dev

? Or are you referring to latest 8,x branch with patches from this issue applied?

In any case, I agree, @salvis, a published release would be great. if it has to be alpha/beta/rc, that's fine.

Thanks @gisle! I've been working back and forth with @salvis of ACL for a number of months, I believe he is committed to a new 2.x stable branch for ACL, which support D10. If I hear more about when this might happen, I will report back.

wow, congrats/thanks @gisle, this is awesome!

thanks @Steven Jones!

can you point me to a build failure or (more ideally) an issue for tracking the outstanding IPE test issue? I cant try to work on it.

I've run it with no issues on 8.1 and 8.2

@joelpittet, is there any way we can get a new release that includes this fix so those of us blocked can move to ctools 4.x?

I think I'm confusing this with the panels commit not being available yet in a release... closing

can we get a new RC release so that we can use ctools 4.x in tandem?

actually, it looks like the 8.x-4.x branch has the right definition:

drupal/ctools": "^3.11 || ^4.0"

So I guess the question is... can we get a new release to include this change?

@joelpittet

do we think the same fix for panels 📌 Change ctools dependency from ^3.12 to ^3.12 || ^4.0 to allow for a smooth upgrade process Fixed will work here? I can submit a patch.

awesome! thanks @gisle :)

xeM8VfDh → created an issue.

@salvis, this can be closed now, I'll let you do the honors :)

this is great news! Thanks everyone for their work, I'm excited we may cross the finish line soon :)

mcdruid → credited xeM8VfDh → .

thanks for all your work @gisle.

I hear your argument that marking 8.x unsupported might cause some users to shift in their seats, but I agree with @Liam Morland... if you've already decided you aren't supporting the branch, then it's perfectly fine (and appropriate, in fact) to make it as unsupported. Transparency on the current state of the module is good and, as you say, may inspire 8.x users to update and provide needed user experience reports/testing.

almost all of the changes I was patching into beta1 to run ACL on Drupal 10 have been incorporated into beta3, which is great!

I am now successfully running ACL on D10 with the following acl-Drupal10-3285916-41.REROLL.patch patch

@salvis, this is supremely disappointing.

the module works on D10. is threre really no further discussion to be had on this? i read comments from you on other issues explaining you'd create a new branch for D10, so why can't we just maintain two branches?

Thanks @salvis, fine leaving this for now if it expedites D10 release

reviewed by @chike in #76

seems to be fixed now, thatnks for the clarification

xeM8VfDh → created an issue.

@Berdir, I am experiencing the same on the 8.x branch as #2 and #3

Since this is a D7 issue, do you want me to open a new issue for this 8.x issue, or are you saying it's not actually an issue with this module but something with upstream Drupal composer?

@salvis, where are we on this?

@salvis

you're doing great @Rajab Natshah!

Is there anything else we users can do here or are we simply waiting on maintainers to jump on this?

#5 works for me

thanks for your work on this @Rajab Natshah.

Would any maintainers care to chime in on this? The ctools and jquery_ui dependency issues (the later of which is fixed in dev, I believe) are blockers for some of us who'd like to be on the latest versions. While this module is not being actively developed for new features, I think these issues squarely fall within the realm of "maintaining current functionality and compatibility". As such, I'd love to see a new release with these fixes. I'd appreciate maintainer feedback and am happy to assist.

I think we should close either this issue or https://www.drupal.org/project/panels/issues/2852655 🌱 Plan for Panels 8.x-4.8 release Active

they seem like duplicates to me

I think we should close either this issue or https://www.drupal.org/project/panels/issues/3359684 🌱 Release Panels 4.8.0 or a new 5.0.x branch and 5.0.0-alpha1 tag Closed: duplicate

they seem like duplicates to me

I'd like to see a new release with support for the 1.x branches of the jquery_ui dependencies, as well as this:

https://www.drupal.org/project/panels/issues/3352307 📌 Change ctools dependency from ^3.12 to ^3.12 || ^4.0 to allow for a smooth upgrade process Fixed

I agree with #5

thanks @japerry. It sounds like those of us on D10+ should use the 4.x branch, and it's just a matter of updating the documentation on the module home page to reflect this.

Thanks for the details @japerry

Do you suggest D10 users who are on the latest everything remain on the 3 branch here, or should we move to 4?

whats the state of the 4.x branch? The module home page still says it's experimental, but also says it works with Drupal 10.

When should users move to the 4.x branch?