- 🇺🇸United States smustgrave
@phenaproxima I like the idea personally as it seems to be addressing the root cause. Wonder if you'll be able to reuse the test case though.
- 🇬🇧United Kingdom altcom_neil
Hi, attached is an update of patch #30 for Drupal 10.3.1.
- First commit to issue fork.
Hi, I was able to reproduce this issue on 11.x. I get the same error as mentioned above.
I tested the same scenario by applying the patch provided in comment #30. The patch worked for 9.4 but needed to be re-rolled for 11.x. I have updated the patch, which applied cleanly and I do not see the error post that. So, I created MR with the code changes.
Attaching the updated patch for 11.x.
Kindly review the MR.- Status changed to Needs review
4 months ago 10:49am 16 September 2024 - Status changed to Needs work
4 months ago 12:59pm 16 September 2024 - 🇺🇸United States smustgrave
Fixes should be in MRs vs patches
And #34 appears to still be needed.
- Assigned to manibharathi ezhimalai ravi
- Merge request !9539Issue #3060292: Drupal\media\Entity\Media::prepareSave should convert URL object metadata to string before saving → (Open) created by manibharathi ezhimalai ravi
- Status changed to Needs review
4 months ago 10:32am 19 September 2024 Hi,
Created the MR !9539 for the changes. Mentioned in the #34 🐛 Drupal\media\Entity\Media::prepareSave should convert URL object metadata to string before saving Needs review already verified that field is instance of the URL or not with the condition.
let me know incase of I missing with adding condition.- Issue was unassigned.
- 🇺🇸United States smustgrave
So I think what we should do here is deprecate retrieving the author_url attribute as a Url object. We could do this by temporarily adding an additional boolean parameter to getMetadata() (just in the OEmbed class -- we would not need to adjust any base classes or interfaces), something like bool $return_url_as_string = FALSE.
Just reading the first part of #34 not sure that's been addressed.