oEmbed videos do not allow full screen

i know it happened and i had this issue .... solving with override template ... years ago.

Checked again ... and i couldn't replicate anymore ... with both drupal 9 and latest 10.1
But also the browser were updated ...
And maybe also what providers provides for their iframes

for example:
Vimeo provides both allowfullscreen="" allow="fullscreen"
YouTube provides only allowfullscreen=""

So. not sure if this issue is still a "valid one" ... And also the related one ...

Could we close it as Closed (cannot reproduce) ?

Is anyone seeing this issue still?

If no response this potentially could be closed.

I also cannot reproduce this issue on a clean drupal 10.1.3 install using the latest Firefox (117), Chrome (116) or Safari (Version 16.5.1) so I believe this can be closed as cannot reproduce, but please feel free to reopen if necessary.

I had this issue show up on my newly updated 10.1 site. #34 fixed the issue and I can go full screen again. I don't know if it makes a difference but my video embeds are all fields within paragraphs.

I can confirm this is still and issue and that the patch in #34 solves the problem.

To reproduce the issue, you must set up a different sub-domain for your oembed/iframe on /admin/config/media/media-settings.

This is a recommend setting by Drupal core for security best practices. If we don't want to just allow iFrame fullscreen for all elements, we should add it as an option that can be enabled to add the dom attribute.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Rolled #34 into a MR

Since this seems like a UI change, even a slight one, could before/after screenshots be added to the summary please.

It looks like they were already on the issue but hidden previously. Revealing them now :)

So I'm not getting any of that behavior using a YouTube video..

Hi,
I am not able to reproduce the issue in the Drupal 11.x-dev version.

Steps Followed as per the commands #7. Both safari and Firefox browser are Fullscreen working properly for the oembed videos.

Tried again and still not seeing the issue or change.

Could steps be added to the summary please.

Hey @smustgrave ,

Just to clarify... You were unable to reproduce the issue following my steps in #53? I know for sure we had the issue with Vimeo videos and that configuration.

I see other recent comments mentioning steps from #7, but the separate sub-domain seems to be the culprit so wanted to verify.

I tested out with YouTube videos maybe that was it?