I noticed a similar issue with the UnsafeAllow3F Apache update that was added to repos around July 1, 2024. I'm running a Drupal multisite and each site runs in a subdirectory of the main domain. Each of these sites has its own block of rewrites in the main .htaccess. For any of the admin URLs to function after this Apache update, I needed to add the new flag like the example below.
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteCond %{REQUEST_URI} ^/example/(.*)$
RewriteRule ^(.*)$ /example/index.php?q=$1 [B,L,QSA,UnsafeAllow3F]
hummeldon, yes this site is using the Bootstrap 3 theme.
After seeing your message I ran another set of tests on the site. I reset the DB again, made sure the module I thought was the culprit was enabled, and ran a drush updb. I got the same error I listed in #5 as expected. This time I kept the module installed and instead switched the default theme to Claro 10.3 and fully uninstalled the Bootstrap 3 (both my custom subtheme and the contrib theme). After changing the theme I ran drush updb and all of the database updates worked as expected. I still encountered the warning "Theme hook simple_menu_icons_css_item not found." related to the simple menu icons module but that was the same behavior I saw with the page from #2.
It looks to me like you're right, this is a Bootstrap issue, but one that only shows up when a theme hook is not found. Hope this helps.
I think I ran into this issue when testing the Drupal 10.3 update on my sites. One of my sites kept generating an error on the drush updb step. Drush would generate the following error:
> [error] TypeError: array_diff(): Argument #2 must be of type array, null given in array_diff() (line 702 of /htdocs/Drupal/web/core/lib/Drupal/Core/Theme/Registry.php) #0 /htdocs/Drupal/web/core/lib/Drupal/Core/Theme/Registry.php(702): array_diff()
After applying the patch #2 I could get through the updb step with this single warning showing up:
[warning] Theme hook simple_menu_icons_css_item not found.
Looking through my sites I realized that the only site the error was showing up on was the one with the simple_menu_icons module enabled. So I rolled the site DB back, reverted the patch, uninstalled the module, and ran updb again. All the DB update applied and no errors were generated. I don't know if this helps with anything but I wanted to share my experience with this issue in the event is helps someone.
Removed a stand-alone s from the second paragraph of the introduction.
johns996 β made their first commit to this issueβs fork.
Commenting here to indicate that #12 is compatible with 4.0.0 running on Drupal 10.1.
I had this issue show up on my newly updated 10.1 site. #34 fixed the issue and I can go full screen again. I don't know if it makes a difference but my video embeds are all fields within paragraphs.
johns996 β created an issue.
The patch applied cleanly to my installation and fixed the issue. I tested it in both the CKEditor instance of a link field and a field using the linkit widget. Nice job Mark! Thanks for your wok on this and everything you've done to keep this great module going.
johns996 β created an issue.
I noticed this impacting media uploads on all of my multisites. Those sites all use a RewriteRule similar to the one listed in #4.
RewriteRule ^(.*)$ /site/index.php?q=$1 [L,QSA]
Updating that to add the [B] flag (escape backreferences) fixed the issue.
RewriteRule ^(.*)$ /site/index.php?q=$1 [B,L,QSA]
I didn't find another place in the .htaccess that needed the [B] flag added and the changes I made were all exclusive to a multisite install. Was there something I missed?