🇫🇷France @flocondetoile

I ran this patch since 4 years without issues. But I didn't have use case with coupons. I used it to make promotions incompatibles with others, without any coupons behavior associated with them.

Rerolled MR5923 for Drupal Core 10.5.1

For those who need the patch without the hook_update_N, as me who run this patch since 4 years (I implements the update_N in a custom module to not break other futur hook_update_N of the module), here it is.

patch rerolled against 3.1.0 version

changed version

This module allows to inject in the HEAD and in the page top the scripts required by Google Tag Manager (for ad word campaign for example). Google_tag module don't do this, and even if Google says that Google Tag will replace Google Tag Manager, in fact GTM is the only module which permit to satisfy the Google requirements about injecting Google Tag Manager in your website (instead of copy/paste their piece of script in the site's template)

flocondetoile → created an issue.

flocondetoile → created an issue.

MR13 fixes the issue with Drupal Core 10.5

greggles → credited flocondetoile → .

Yes, better to wait that this module works again before publish a release...

2.x version fixed

Thanks for reporting.

You should revamp your theme for table of contents and go with 3.x version. It's not a big deal to add some css rules to visually flatten the TOC.

If you can confirm me this is working well on Drupal 11, I will be able to publish soon a new release. ?

If you can confirm me this is working well on Drupal 11, I will be able to publish soon a new release.

Thanks

Thanks. Committed

Any patch / MR ?

Thanks. Committed.

mparker17 → credited flocondetoile → .

Thanks. Patch slighty updated and committed.

Tests are failing

Added a .gitlab-ci.yml too, to launch existing tests

beta3 released

But you need to check the status (as you do in your patch) too juste before deleting it. An order can be locked after being added in the queue expiration

Hello. Better to do this at the query level no ?

In the commerce_cart.cron service

protected function getOrderIds($order_type_id, Interval $interval) {
    $current_date = new DrupalDateTime('now');
    $expiration_date = $interval->subtract($current_date);
    $ids = $this->orderStorage->getQuery()
      ->condition('type', $order_type_id)
      ->condition('changed', $expiration_date->getTimestamp(), '<=')
      ->condition('cart', TRUE)
      ->range(0, 250)
      ->accessCheck(FALSE)
      ->addTag('commerce_cart_expiration')
      ->execute();

    return $ids;
  }

Youhou ! My older issue I believe :-) Thanks !

Committed. Thanks.

This patch should resolve this issue.
Patch done on /2.x-dev / 2.1.0 version.
Could you give a try ?

Thanks everyone. Committed.

flocondetoile → created an issue.

This module uses the node access system. So it can only control access to node, not on others entity types, as media.

I 'don't understand the issue reported. Need reformulation and/or actionnable elements.

There is already a patch in 📌 Automated Drupal 11 compatibility fixes for pbf Needs work and it looks nobody has test it yet.

You can write your own custom field widget for the pdf field and use it instead of the default one provided.

May be you just don't need this module if it don't meet your need.

Without error message we can't do anything. Please provide more actionnable elements about this crash.

flocondetoile → created an issue.

This module should not altering this behavior. It's not its responsabilities to add the user.roles context for local action links. Your fix does the job, but doesn't fix the root cause I think. The best way would be (perhaps) to stop overriding route.route_provider and start using addExtraCacheKeyPart() (as domain did it see https://www.drupal.org/project/domain/issues/3359253 ✨ Use core route provider with addExtraCacheKeyPart for route caching? Needs review ).

But is this override which is the root cause ? What happens if this module stop to override the Class of the router.route_provider service ?

No. Already on it...

What impact of such change if content_moderation is not enabled on a project with micro_site ?

I don't understand why micro_site is involved with the /admin/content page (it only provide site entity and related features, and don't change change the node behaviors). This module don't change this page, and don't change any permissions. You should have same bug without micro_site enabled ?

MR11 is not mergeable.

Also you changed the entity type definition for the Site entity.
So you need to update this definition too for existing sites, with a hook_update_N. See https://git.drupalcode.org/project/commerce/-/blob/3.0.x/modules/order/c... (commerce_order_update_8210()) as an example.

flocondetoile → created an issue.

Hope the module works fine on D11, as you tell here. I didn't test it on D11 yet.

The new release is coming

So I close this issue. Anyway I plan to release a D11 compatible version of the module soon.

flocondetoile → created an issue.

There's no hurry. It can wait if other small bug fixes crop up soon. I'll let you decide.

Yes. Thanks. Forgot there is the 3.1.x branch

flocondetoile → created an issue. See original summary → .

flocondetoile → created an issue.

Thanks for the reminder

Another patch with the value TRUE for TemplateLanguage this time.

Given the doc (https://dev.mailjet.com/email/guides/send-api-v31) not sure the value of the TemplateLanguage should be the language id, but instead just the value TRUE ?

Does this patch fix your issue ?

Hello. Thanks for reporting and the patch. I'll commit it with a slight change.

flocondetoile → created an issue.