Use core route provider with addExtraCacheKeyPart for route caching?

I ended up having to truncate the cache_container table to stop it giving me a fatal error related to the service argument change. Is there a better way to deal with that?

Interesting. It looks like this was added in Drupal core 8.9, after the module handled the cache problem.

When using this patch, you have to rebuild the container with `drush cr`.

I would put this in 2.0.x and skip 8.x.1.x.

You must also set patches to "Needs Review" to trigger automated tests.

I had the same idea today, that we can replace the piece again, because it is now possible to extend the cid with.

Lets see what tests say.

@tobiasb The MR does not longer apply, please rebase. Thanks!

I thing we should also delete \Drupal\domain\Routing\DomainRouteProvider. In a perfect module we would deprecate it and also add a fallback/deprecation to \Drupal\domain\EventSubscriber\DomainSubscriber::__construct.

Tanks, to all. I have decided to remove DomainRouteProvider entirely (without BC layer). I think most since don't use it as extension point. It was never intended to be used as extension point. Those use cases are covered by CacheableRouteProviderInterface::addExtraCacheKeyPart.

I am sorry if this breaks a site.

webflo → closed merge request !67

Automatically closed - issue fixed for 2 weeks with no activity.