[regression] Restore styling for embedded media edit button in Seven theme

Open on Drupal.org →

Created on 6 November 2019, about 5 years ago

Updated 9 September 2024, 5 months ago

Problem/Motivation

Unthemed Edit Media button:

See #3092779-10: media_library.theme.css is being called despite it no longer existing →

When the Media Library styles were moved into the theme layer, the fact that one stylesheet was being added in DrupalMedia.php was overlooked. Consequently, the "Edit media" button is now unstyled in the Seven theme.

Proposed resolution

Add styles from Media Library for the Edit Media button in the seven theme, or in the Media Library module.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Closed: outdated

Version

11.0 🔥

Component

Last updated about 1 hour ago

Maintained by
🇳🇱Netherlands @seanB
🇩🇪Germany @chr.fritsch
🇺🇸United States @phenaproxima
🇪🇸Spain @marcoscano

Created by

🇺🇸United States oknate Greater New York City Area

Live updates comments and jobs are added and updated live.

Needs frontend framework manager review
Used to alert the fron-tend framework manager core committer(s) that a front-end focused issue significantly impacts (or has the potential to impact) multiple subsystems or represents a significant change or addition in architecture or public APIs, and their signoff is needed (see the governance policy for more information). If an issue significantly impacts only one subsystem, use Needs subsystem maintainer review instead, and make sure the issue component is set to the correct subsystem.

Usability
Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Needs manual testing
The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Media Initiative

Triaged Media Initiative issue

NorthAmerica2021

Easy Out of the Box

Bug Smash Initiative

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States Nuuou Lincoln, NE
Re-rolled Patch #41 with CKEditor 4 in Contrib
Comment almost 2 years ago →
🇺🇸United States matia.ward
Fixed the icon path.
Comment almost 2 years ago →
🇺🇸United States Nuuou Lincoln, NE
#43 is not applying for me for some reason, attaching a new patch that should be identical to #43.
Comment over 1 year ago →
🇺🇸United States Chris Matthews
There is a patch → in #44 🐛 [regression] Restore styling for embedded media edit button in Seven theme Postponed: needs info , however, @larowlan's questions in #40 still need to be answered, which is why the status for this issue is Postponed and not Needs Review.

Does this impact CKEditor 5?
With CKeditor 4 moved to contrib should this issue be moved to contrib?
Status changed to Closed: outdated 5 months ago12:09am 9 September 2024
Comment 5 months ago →
🇦🇺Australia acbramley
This came up again in Bugsmash today. It has been over a year since this was set to PMNMI and no further information has been provided.

The seven theme no longer exists in core and I can't see that CSS file either that the patch is changing. Therefore I'm marking this as Closed (outdated).

Please feel free to open a new issue with steps to reproduce this bug from a fresh drupal installation.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024