It is possible to overflow the number of items allowed in Media Library

The patch #159 works for us on 9.5.2 - thanks!

Patch #159 works fine on 10.1.x-dev only when one Media type is enabled.

After applying patch:
1. When only "Image" media type is enabled in the Media Library then warning is displayed on exceeding allowed limit and error is displayed on clicking "Insert Selected".

2. When multiple media type is enabled say "Image" , "Document" then no warning is displayed on exceeding media selection. However, error is displayed on clicking "Insert Selected".
Expected Result: Warning should be displayed when combination of media type is selected and count exceeds allowed limit.

Wonder if this is any better?

core/modules/media_library/js/media_library.ui.js on 9.5.x is different from 10.1-x-dev, rerolled this patch for 9.5.x, hope it helps.

Tried to fix CCF for #166.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Re rolled the patch #167, the patch doesn't apply anymore

#164 still does.

@smustgrave in #166 it was reported that core/modules/media_library/js/media_library.ui.js on 9.5.x is different from 10.1-x-dev

I don't know, but just not sure if you're suggesting that #164 is the patch we should be using or what...

#164 should be used for testing on 11.x or 10.x

Can determine if we will backport to D9 after I suppose.

Tested patch 3059955-164.patch on DrupalPod, I used Drupal 10.1.x

This patch is working as proposed solution suggests, if selected number of items exceeds maximum number of allowed items, a warning message is displayed. If user tries to click 'Insert Selected' an error message is displayed and the user is not allowed to insert any items.

Ran yarn prettier to try to make the custom commands pass.

Made a minor fix on commit, attached interdiff.

Committed ae4b724 and pushed to 11.x. Thanks!

Leaving open for potential backport to 10.1.x.

Got a +1 from @catch for the backport to 10.1.x during RC.

Wow, thank you all for getting this done! ❤️👏

Hi , I am adding a patch for the issue where i was not able to add any documents from "Add Media" .This has worked for me.

@Swayanka I think we should file a new issue for the bug you are reporting 😊

Automatically closed - issue fixed for 2 weeks with no activity.