- ๐ท๐บRussia Chi
Use form element of type date instead textfield when selecting a date in an exposed filter
And to be consistent we should use
datetime-local
element when selecting a datetime in an exposed filter. Might be worth a follow-up to try to remove the overrides, then we wouldn't need to update them in Drupal 12 except for when we delete them.
There are a lot of them:
core/modules/block/src/BlockListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/block_content/src/BlockContentTypeListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/comment/src/CommentTypeListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/field_ui/src/FieldConfigListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/filter/src/FilterFormatListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/image/src/ImageStyleListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/menu_ui/src/MenuListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/node/src/NodeTypeListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/responsive_image/src/ResponsiveImageStyleListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/search/src/SearchPageListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/shortcut/src/ShortcutSetListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/taxonomy/src/VocabularyListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/user/src/RoleListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/views_ui/src/ViewListBuilder.php public function getDefaultOperations(EntityInterface $entity) {
Two content entity list builders too:
core/modules/menu_link_content/src/MenuLinkListBuilder.php public function getDefaultOperations(EntityInterface $entity) { core/modules/menu_link_content/src/MenuLinkListBuilder.php public function getDefaultOperations(EntityInterface $entity) {
They do various things, so I don't think they can be removed.
Of relevance to this issue, these implementations of
getDefaultOperations()
include access checks inside them, so I wonder if cacheability needs to be captured.
core/modules/field_ui/src/FieldConfigListBuilder.php
core/modules/taxonomy/src/VocabularyListBuilder.php
core/modules/workspaces/src/WorkspaceListBuilder.php- ๐ฆ๐บAustralia acbramley
Do you know why?
It looks like it might have been accidental. See the following commit where
public function getOperations
was changed topublic function getDefaultOperations
https://git.drupalcode.org/project/drupal/-/commit/b504423ed07e9bb437e96...
Added ๐ getDefaultOperations() in ConfigEntityListBuilder and sub classes should be protected Active