getDefaultOperations() in ConfigEntityListBuilder and sub classes should be protected

I will give this a try!

I’ve only changed the getDefaultOperations() method of the ConfigEntityListBuilder class to protected. Is there any other place where this change needs to be reflected or updated?

core/modules/block/src/BlockListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/block_content/src/BlockContentTypeListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/comment/src/CommentTypeListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/field_ui/src/FieldConfigListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/filter/src/FilterFormatListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/image/src/ImageStyleListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/menu_ui/src/MenuListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/node/src/NodeTypeListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/responsive_image/src/ResponsiveImageStyleListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/search/src/SearchPageListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/shortcut/src/ShortcutSetListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/taxonomy/src/VocabularyListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/user/src/RoleListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/views_ui/src/ViewListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {

Oh, and a couple content entity list builders override as public as well:

core/modules/menu_link_content/src/MenuLinkListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {
core/modules/menu_link_content/src/MenuLinkListBuilder.php
  public function getDefaultOperations(EntityInterface $entity) {

I wonder that since these methods are public now, we can't just change them to protected right away, but need to trigger deprecations and add a CR that they will be changed to protected in D12.

Hi @godotislate thanks for providing the whole list. So instead of changing it to protected should I add deprecated message?

I'm not sure how the deprecation message would work. We'd need the differentiate the between internal and external calls, that sounds complicated and slow (checking backtrace?).

These were never meant to be called directly and doing so would be result in incomplete and broken results. Making it protected won't break subclasses, it's possible to extend the visibility of a protected method in the parent class.

I can't find any calls that aren't $this->getDefautOperations(), I'd say we either just do it or we don't bother and leave it?

@libbna sounds like you can go ahead and change all those methods to protected per #10.

Sure. Thanks! I will do it EOD.

There was test failure, so I rebased. Test pass now, so this LGTM.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.