🇮🇪Ireland @stella

the font is too big for my screensize

Screen/browser details: https://www.whatsmybrowser.org/b/CSD9W

Issue reported in #53 above is still an issue on https://new.drupal.org/node/10000007 on the 2nd slide

jjchinquist → credited stella → .

jjchinquist → credited stella → .

jjchinquist → credited stella → .

jjchinquist → credited stella → .

jjchinquist → credited stella → .

@klausi provided the initial patch for Drupal 10, it needs review and backporting to Drupal 7. Please grant him issue credit.

stella → created an issue.

jjchinquist → credited stella → .

glad you got it sorted

dan2k3k4 → credited stella → .

Yep, credit is given for questions used.

Thanks to everyone who contributed questions to Trivia night in Lille!

Patch reroll for undefined $response variable warning.

stella → made their first commit to this issue’s fork.

stella → made their first commit to this issue’s fork.

DamienMcKenna → credited stella → .

You need to contact Realex / Global Payments to get these information. I don't know if it's available through their portal, but you'd have to ask them for those values.

Closing as a duplicate of #3272128

stella → created an issue.

When testing the actual sending of the notifications I got this error:

The website encountered an unexpected error. Please try again later.

Drupal\Core\Entity\EntityStorageException: The "group_content" entity type does not exist. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Drupal\Core\Entity\EntityTypeManager->getHandler('group_content', 'storage') (Line: 192)
Drupal\Core\Entity\EntityTypeManager->getStorage('group_content') (Line: 205)
Drupal\content_moderation_notifications\Notification->sendNotification(Object, Array) (Line: 100)
Drupal\content_moderation_notifications\Notification->processEntity(Object) (Line: 36)
content_moderation_notifications_entity_insert(Object)
call_user_func_array(Object, Array) (Line: 426)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'content_moderation_notifications') (Line: 405)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('entity_insert', Object) (Line: 433)
Drupal\Core\Extension\ModuleHandler->invokeAll('entity_insert', Array) (Line: 251)
Drupal\Core\Entity\EntityStorageBase->invokeHook('insert', Object) (Line: 903)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('insert', Object) (Line: 598)
Drupal\Core\Entity\EntityStorageBase->doPostSave(Object, ) (Line: 784)
Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object, ) (Line: 523)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 804)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 339)
Drupal\Core\Entity\EntityBase->save() (Line: 270)
Drupal\node\NodeForm->save(Array, Object)
call_user_func_array(Array, Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 595)
Drupal\Core\Form\FormBuilder->processForm('node_blog_form', Array, Object) (Line: 323)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'default', Array) (Line: 391)
Drupal\group\Entity\Controller\GroupRelationshipController->createForm(Object, 'group_node:blog')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

This because the "group_content" entity has since been renamed to "group_relationship".

Updated patch attached for that one change.

Updated version of the patch with the change from #41 rolled back.

I get the following error on the settings page with latest version of the module and Drupal 9.5.9

The website encountered an unexpected error. Please try again later.
Error: Call to undefined method Drupal\group\Entity\GroupRole::isInternal() in Drupal\content_moderation_notifications\Form\ContentModerationNotificationsFormBase::Drupal\content_moderation_notifications\Form\{closure}() (line 248 of modules/contrib/content_moderation_notifications/src/Form/ContentModerationNotificationsFormBase.php).

If I remove the check for isInternal() introduced in #41, then the page loads. However, it still has no group roles appearing on the form as a result of the rest of the change in #41 as I have no "member" role. I have editor and other roles, and none called "member", so I think that change is too restrictive and doesn't work for every scenario.

That would be pretty cool - you could then, for example, have a social media planner - so schedule your content and social media posts in one calendar.

Thanks for the patch! This solved a big issue for me.

Here's a slightly revised patch with the following changes:

1. Removes the alert() of result.message on successful change - this is simply just annoying to the user if already familiar with the likes of Trello etc
2. Simplified the revision log message stored - there is no need for the entity type or the entity id as it is saved against the entity changed.

I think it's good to go as is, just to summarise what this patch does:

• For each of the top level admin menu items (admin/build, admin/user, etc), it changes the access callback to be a new function system_admin_menu_block_page and gives it the params: path (e.g. 'admin/build') and the access permission.
• The function first checks that the user has the appropriate access, and if not returns FALSE.
• then checks if the user has access to any of the sub-menus, and if not it returns FALSE, which prevents the user from seeing the menu item

Actually this also change also needs to be implemented for the new top level admin menu admin/international in locale.module

Patch looks good and works quite well. However there's still one edge case that isn't covered - if the user has the 'access administration pages' permission, but doesn't have access to _any_ of the sub menus, and if the help module is not enabled, then the 'Administer' menu item still appears in the navigation block and the message "You do not have any administrative items." appears when clicked.

It's an edge case (why would anyone give that permission to a user without giving them access to at least one sub-menu?!) and the message displayed is useful, but shouldn't that menu item not appear at all?

Since #363951: Reintroduction of MENU_ITEM_GROUPING → won't be committed (marked as won't fix), does this mean we're back to the patch in #20 above?

subscribe