Field tokens for "historical data" fields (revisions) contain a hyphen, breaking twig templates and throwing an assertion error

With patch #152 applied on 9.4.8, I get an error when I try to save my view.
ParseError: syntax error, unexpected ')' in Composer\Autoload\includeFile() (line 587 of core/modules/views/src/ViewsConfigUpdater.php).
After looking at the code, it seems the foreach line 587 is indeed incomplete:
foreach ($displays) {
Also, the new tokens don't seem to be available...
Patch #151 does bring the new tokens which works great thanks and does not prevent saving the view.

I redid the re-roll of the patch from #146 and then re-added the tests in #139.

Fixed CCF for #156.

The last submitted patch, 157: 2831233-157.patch, failed testing. View results →

Tests are back as of a few patches ago.

1. Fixed the initial test fail by adding a UUID to the fixture yaml.
2. Fixed the actual failure by referencing $display by reference.
3. Fixed the doc block for processRevisionFieldHyphenFix
4. Added various return types, etc

So to get back to my point in #82, we still miss a proper test-only patch that proves we are fixing a bug here.

So here is my take on that, changed the test view to use the old replacement token en matched the test to use that token. As expected it fails, but now we have proof.

Also uploading the patch from #159 again to make the testbot happy and it won't get stuck on the test-only patch

The last submitted patch, 160: 2831233-TEST_ONLY-160.patch, failed testing. View results →

Confirmed the issue following the steps in the IS.
Applied patch #160 which solves the issue
Also patch TEST_ONLY-160 shows the issue.

Think this will need a change record to announce the new public function processRevisionFieldHyphenFix

The last submitted patch, 168: 2831233-168.patch, failed testing. View results →

Another random failure

Updating issue credits

Committed to 10.1.x

Not backporting because of update path

Automatically closed - issue fixed for 2 weeks with no activity.

I know this is closed and I am late to the game here; but do I have this right?

In D10 historical fields in views were changed from __revision_id to -revision_id. There was no updb script for this, so when i migrated to D10 a bunch of views now have broken/missing handlers. And then, once i go through and fix all of these by re-adding all these fields, all the rewrites are broken because twig can't handle the new field values in its tokens?

And the fix here, is to preprocess the twig token values and put them back to what they used to be (D9)? Silly question, but wouldnt it have been easier (and not broken a ton of sites) to just change the field ids back to what they were?

That being said, anyone know if any of these patches apply to D10.0? Haven't found one yet. :(

No, it does seem like this patch is putting the views field ids back as they were in D9 __revision_id. Yay!

Couldn't find a patch here that worked with 10.0.11 so attaching one here. It is based off the patch from #168.