🇦🇺Australia @gordon

joelpittet → credited gordon → .

My client is having this issue.

Basically it is manifesting itself on the table element. Basically we have written a plugin for tables which allow us to add classes to the table element. This worked perfectly under D10.1, but then broken when we migrated to 10.2. The problem is that when we edit content with a table element, all the classes are stripped from the table. So before we save any content we need to re-apply the styles again.

I have tested all the patches and none of them are working.

#75 didn't really do anything. I had to reroll it so it would work with 10.2.6, but didn't resolve the issue.
#38 Fixed the issue when configuring the source editing, but didn't solve the issue with editing content that has tables with classes. It did resolve the issue of fixing up the classes in the filter html

I also tried MR!7888 but this didn't do anything as well, but then again this MR doesn't really change much.

I have fixed the markup. Too much time in Jira :(

I tried looking for related issue but I couldn't find one Any pointers to this would be great.

gordon → created an issue.

gordon → created an issue.

gordon → created an issue.

I have done some more testing and this is working great and is just about RTBTC, except for 1 thing. Basically the HTML structure is there but there is no styling for the word/character count.

It is looking really good.

Can we get this committed into a 3.x branch which only supports CKEditor 5.

Installing 2.x, currently has dependencies on CKEditor 4 which gets it installed even if we don't need it. Also deploying to a 3.x branch will make it a lot easier for people to test and it is it just a dev release everyone knows what to expect.

I have done this for other projects and it really speeds up the final development as it easier to deploy and test.

I have added my initial change to allow the processing multiple datasets from the drush command. Also this change allows for the use a globs to allow basic selection.

gordon → created an issue.

gordon → created an issue.

This problem seems to be related to #2738051 🐛 \Drupal\views\Plugin\views\query\Sql::getCacheTags and getCacheMaxAge don't take into account that some entities can be NULL Needs work , but in my case the other didn't fix my issue but caused another issue, and this one fixed it. They both seem to be a very similar issue and solved in slightly different methods.

I have just ran across this issue and I do not think this is a good solution. It fixes the TextAreaWidget and descendants but not any other type of field will be similar (Single widget which has multiple fields).

From the example above.

$this->context->buildViolation($constraint->someMessage)
          ->atPath((string) $delta . '.value')
          ->setInvalidValue($text)
          ->addViolation();

When creating the violation as above using the `::AtPath('value')`, the WidgetBase::flagErrors() is then splitting all the violations into 2 groups. A delta list and an item list. The delta list is basically, the violation has the path of `body.0.value` and everything else goes into the item list.

Since this is a delta list it uses the delta and anything after the delta is discarded (In this case the `value` is not used). In reality it should use the rest of the path after the delta to find the element that the error should be added to.

acbramley → credited gordon → .

Fixed

I have fixed up the 2 items that I have found which break local URL's and I will do some more testing.

gordon → created an issue.

This looks great and the tests look fine as well.

I found that the post update didn't have the correct function name, (it was using the template version) and also cleaned up the comment to why we need to do this in the code.

Also I have moved this into a repository which will make it easier to check,

1. I have fixed up the typo and added in an update to update to set the default value.
2. I have looked into this and to test the regular expression is to use preg_match(). If the expression is invalid it will return false, as opposed to not matching which will return 0.
3. I have added in a test to check the if the exclusion will work.

Actually there is a major difference between `base` and `internal`. Base will treat the URI and a complete path and urlencode() the path as it should. However the problem is that if your URI has a query or fragment than these will be encoded as well.

Using internal actually negates this issue and will split out the query or fragment and encode it correctly in the Url object.

based upon the issue that I was having, we should treat all URL's as internal so they are no broken when they are urlencoded.

I have made a small change to the matcher so that when the search is done, on searches of local anchor links, (i.e search string begins with a #) it will only search for uri which start with a #.

Move to correct project.

gordon → created an issue.

I have tested this change on D10.2 and the problem was resolved for the node edit page. However the toolbar is still moving down on Layout builder page.

I am going to hunt through and see if there were any fixes between 10.1 and 10.2 for the displace library.

We are running Drupal 10.1.

Thanks for this, it has fixed the main part of the problem but there seems to be a problem with the displacement of the toolbar.

On the normal node edit I get the following.

and on a layout builder screen I get this.

Basically on both pages when you click on the edit area the toolbar will move down as shown.

Also on the layout builder screen the admin toolbar was over the editor toolbar until I started editing and it moved down.

gordon → created an issue.

gordon → made their first commit to this issue’s fork.

Hi, Sorry for the delay. because CKEditor 5 was not "ready" for primetime for my client I was redirected to upgrade our site to Drupal 10.

Basically right now if linkit embeds the dropdown for the autocomplete in the form. When you are just running the standard ckeditor 5 link plugin there is nothing below it except the ✔ and the ⛌ of the ck balloon drop down. When you start enabling other modules like editor advanced which adds additional fields below the url the drop down starts to no look correct.

Also other problems occurs when the balloon is lengthened by the auto complete it can push the lower items off the bottom of the screen making them unaccessible.

What I would like to see is something like the jQuery UI autocomplete which pops the list out and doesn't expand the window. It would be better if it was how linkit does it in CKEditor 4 where the list expands over the following elements and not push them off the page.

I am closing this support for CKEditor 4 is present it is just very broken.

I have tested this and it resolves this issue and stops it from crashing.

gordon → made their first commit to this issue’s fork.

gordon → created an issue.

Here is a patch to fix this. I also added a post update which will check all the existing links and url decode them.

gordon → created an issue.

Wim Leers → credited gordon → .

I just had this issue and I have been able to work out exactly what this issue is.

Basically in my case I had configured everything and went on to do some other tasks. When I came back I was getting the above error. I followed the advice above and managed to fix it, however the problem turned out that I had a missing CKEditor5 plugin.

So I had originally ckeditor templates installed with the ckeditor5 patch applied. Then after I had switched tasks and back I did not have this patch applied and I got this error.

So if you make sure all the plugins you are using exist on the system.

I am reopening this issue because this should fail gracefully and not just a block of JSON.

I have rerolled this patch as it conflicts with the Drupal 10 upgrade patch. Bascially I have reverted the info.yml and removed the composer.json so both patches can be applied.

I created this core issue #3393441 🐛 Stable 9 is trying to override non-existing css files. Active which actually related to this. Basically it seems that the dialog css has been refactored so now the css files are not correct at all.

gordon → created an issue.

I have made some additional changes I hope will fix some more.

gordon → made their first commit to this issue’s fork.

I found another issue and fixed out.

This was a pretty small change with a new config entry.

gordon → created an issue.

I have investigated this further as I couldn't apply this patch to 10.1. The resolution says "Closed (works as designed)" however this patch was added to 10.1.x but not via this issue. This may have not been as issue at all and was just updated as part of updates to Symfony.

Rebase patch against 10.1

@mark-shi I am not sure what you did in #83, I went to merge this into the issue branch but there ended up being no changes. In fact this was not a complete patch as there were other changes which were not included.

Your contribution is appreciated but please use the issue fork as described here →

This is a complex change and colborating via the issue fork will make things a lot easier.

Rebase again so it can be applied to 2.x

I have removed the original patch.

Hi,

I have changed this into an issue fork and added the necessary changes so that when it does the API check it will use the real config which includes any overrides.

Hi

Thanks for this but this change then breaks the republish check.

So in my clients case we override the user and api key and set these fields to ‘’ in config. So when loading this page it will do the checks with user and api key set to null were it should be using the overridden value.

There needs to be a change further down where the check will be done not using $config but using a a different version of the config using configFactory() and then the creds will be loaded correctly if they are overridden.

Thanks for the fast work.
Gordon.

gordon → created an issue.

I have not looked at this issue in a while and it was a huge mess. There was no way to see the changes made as there were no interdiffs created making it very hard to track.

I have spent some time going though all the patches and merging them all into !MR4 so we can see the changes. Also I have removed all the Drupal 10 compatibility changes from 📌 Automated Drupal 10 compatibility fixes RTBC as this is not related to this issue. But we do need to make sure that any new code here should be D10 compatible Also the one line patches that were being uploaded we not being loaded into the larger patches and had actually already been fixed in !MR4 which made things difficult.

Thank you both @devanbicher and @mark-shi for your work. If you can check the changes I committed to !MR4 from your patches and make sure I didn't break it too much would be really great.

Also if we can do any additional development is the issue fork would make it so much easier moving forward. I know it is not easy with composer but this is important work and the goal is to get ckeditor_templates working for CK5 and released. If we have to create local patches for our sites that is a small price.

I merged in the @jaspreet21 changes. However I didn't include the changes to the info.yml as retaining compatibility with Drupal 8 is really not realistic.

Ive created a MR to fix this issue.

gordon → created an issue.

Yes can we please get this committed. It would make things much easier.

However I am using another tool called Drupal lenient, which can install modules that need to be that don’t quite match the criteria.

I am currently down to 2 remain modules which don’t have A d10 release.

I continued to investigate this and I managed to solve the problem.

Because of the commit above I found that the caching is a bit more strict. I found that I needed to add context to the block.

Basically my offending block was was grabbing the node from the route and using that to render. So by adding context to the block so it knows that it is using the node then fixed my issues.

I found the resolution to the issue from #2980324 📌 Document how to use block contexts Fixed which solved the issue of the and then everything worked as required.

I am not sure if this is same problem I am having but when I reversed commit 14e6be6 it solved my problem when running during testing (phpunit) on one of our custom blocks.

gordon → created an issue.

I did some more checking and I have removed the composer.json as it added no benefit and a better version will be generated by drupal.org

I have been testing this as a part of my clients Drupal 10 upgrade testing. This is looking good and getting this committed will make it easier for other people to test with Drupal 10.

I have also been testing this as a part of Drupal 10 upgrade. So far everything is looking fine, and it would be great if we can get this committed so it will make it easier to test.

Thanks.

I have been doing a lot of testing of this as a part of moving to Drupal 10. I have not found any issues and would make it so much easier.

If you can commit this would be such a huge help for my client.

Reroll the patch

Reroll patch

Fixed up a conflict that occurred.

Here is a version which will apply to 2.x

gordon → created an issue.

gordon → created an issue.

I was not aware of this in #states issue but if in the form API you set the #disabled to false as in the above example CKEditor 4 will be disabled.

#15 resolved it for me, but I have also created a patch so that I can included this to make it repeatable when I install this.

I have submitted on PR#63 to drupal-finder to add a new method to find the vendor bin.

I have attached a patch which uses the above PR to implement a better method of finding the rector executable.

Also I noticed that there is no support for the "vendir-dir" config option as well, which changing to fully using drupal-finder will also resolve this problem.

One thing I didn't do is add a new composer file so we can have the dependency on drupal-finder.

gordon → created an issue.

@frob FYI I have done some work on back porting v38 to Drupal 9.5. I now understand why it is not being back ported past Drupal 10.1

I have done the back port and it is working well enough to test this issue and confirm that when we upgrade to 10.1 will be able to move to CkEditor 5. However in v36 up (which were both in D10.1) there was a change in the plugin API which caused crashes of CKEditor 5. (See https://www.drupal.org/project/editor_advanced_link/issues/3350254) which I have found it also effects link it as well.

For testing of v38 i think this is fine, but I do not think this should be used in production.

gordon → created an issue.

I rerolled the patch to apply to 6.2

I just got very excited but then disappointed since there is no CKEditor 5 support.

I assume that this works great in CKEditor 4, but version 2.x adds support for CKEditor 5 so this needs work in both 4 and 5.

Changed back to needs work.

I have found another issue. Not sure if this is a big one but it will cause problems.

CKEditor 5 is much more integrated than what 4 was. Eg. when you add buttons it will upload the allowed HTML tags will get updated. This is great however when you add in a template we need to add in the tags the template uses into the allowed tags. Basically what happens is the tag just disappears.

eg.

<blockquote>
  &ldquo;The quote.&rdquo;
  <cite>The citation (optional).</cite>
</blockquote>

So we have the blockquote added to the allowed tags, however we did not have the cite tag so it was just stripped.

I am not sure if we need to do anything for this. or we need to update the filters which we have connected the template to. I did run into another issue when I tried to add in the (in my case) cite tag and I was unable to edit the allowed tags. I have not done the additional investigation but I suspect ckeditor5 is stopping this.

I found an issue with different themes having different classes on the form element wrapper so the selector was not always targeting it correctly.

After some investigation I found that the best classes to target are the js- prefix classes which seem to be on all the core themes that I checked. So I have cleaned up selectors on the dialog to use the js prefixed versions and reduced the selectors to only one.

I have raised an issue against core for the lack of support #wrapper_attributes see #3352581 which explains this.

gordon → created an issue.

I have fixed the issue with the styling not being applied as I described in #45.

Basically the class form-radios cannot be depended on as some of the base themes do not add this class (stable and stable9) and some do.

The second problem is that the radios theme doesn't support #wrapper_attributes so I have had to add a hack to add support for this so we can add a new class form-radios--templates which we can target instead of form-radios.

I have attached the patch, but I have excluded the last couple of patches as I was not being able to apply these patches.

I have figured out the problem that I am having with the CSS not being applied.

Basically for me, in a standard node edit page the radios element uses (for me) the clario form-radios.html.twig template which adds the class form-radios. When using CKEditor in layout builder it is using the stable form-radios.html.twig.

I am not sure if this will be an issue for 10.x but it is an issue for 9.x

I have done more testing of this, and I have found that this is more cosmetic as if you submit changes when the textarea is disabled, Drupal will just throw away the changes and keep the current changes.

However from the user perspective it is not doing the expected outcome. You are able to enter content or make changes, and then these are not saved.

gordon → created an issue.

I have found a pretty major problem. I am not sure how to fix it.

Basically if you load up ckeditor inside layout builder the css template doesn't get applied.

I checked and it is being loaded, but not in a way, that the ajax will not reload, but it is not being treated as css.

Thanks for this. It fixed a a lot of problems.

There are still other problems with colours. the Source view and the hr are still there.

I have also added a patch for Drupal 9.5

I have been doing some changes so that my client can finish their upgrade to CKEditor 5.

It is now pretty much working really well and I am about to pass this onto testers.

1 issue I have is that the templates are being loaded via AJAX. We should add this as a part of DrupalSettings which will mean it will be loaded much faster and make the 5 plugin experience the same the 4 plugin.

gordon → made their first commit to this issue’s fork.