Settings form is not accessing config correctly.

please review the patch

Confirmed that the given solution works.

Updated settings.php file

Before patch

After patch

Hi

Thanks for this but this change then breaks the republish check.

So in my clients case we override the user and api key and set these fields to ‘’ in config. So when loading this page it will do the checks with user and api key set to null were it should be using the overridden value.

There needs to be a change further down where the check will be done not using $config but using a a different version of the config using configFactory() and then the creds will be loaded correctly if they are overridden.

Thanks for the fast work.
Gordon.

Hi,

I have changed this into an issue fork and added the necessary changes so that when it does the API check it will use the real config which includes any overrides.

I have removed the original patch.

We have a conflict with https://www.drupal.org/project/siteimprove/issues/3308624 💬 Question with Config Overrides/Key module Fixed

In that issue, the code was specifically changed from $config = $this->config('siteimprove.settings'); to $config = $this->configFactory->get('siteimprove.settings'); to allow config overrides.

Oh, I think I understand the issue now. You don't want the overridden value to be displayed in the settings form, but the overridden should still be used in API calls.

Automatically closed - issue fixed for 2 weeks with no activity.