My issue is that when the translations are also cloned, they keep the owner and date. This can prevent an editor from removing unwanted translations.
Also, if the editor doesn't have access to edit or delete content in specific languages, this can pose a problem, but that's a different issue.
I have attached a patch that makes sure that all cloned translations have the same uid, created, changed, and revision_timestamp as the cloned original language.
There is a module for this: https://www.drupal.org/project/siteimprove_analytics →
I'll close this issue for now. If it will be decided to add that functionality to this module (e.g. as a sub module), that will be handled then.
I have added some documentation to the module's page.
Added documentation of how to enable Siteimprove Analytics.
Patch merged to 2.0.x.
Fixed in latest dev version.
I'm going to need some more information. I can't reproduce the error on a freshly installed Drupal 10.1.0 or Drupal 10.1.2.
The only way I can see that any checkboxes in SettingsForm.php could be null and thus producing the mentioned error, is if node_type_get_names(); returns null, and the documentation says it returns string[], so I'm puzzled as to how you can get this error.
If either there are no node types, taxonomy types, or group types (and the group module has been enabled), then all the checkboxes variables will be empty arrays which is fine.
Oh, I think I understand the issue now. You don't want the overridden value to be displayed in the settings form, but the overridden should still be used in API calls.
We have a conflict with https://www.drupal.org/project/siteimprove/issues/3308624 💬 Question with Config Overrides/Key module Fixed
In that issue, the code was specifically changed from $config = $this->config('siteimprove.settings'); to $config = $this->configFactory->get('siteimprove.settings'); to allow config overrides.
beltofte → credited bartvig → .