Wrong request sent on group pages

Created on 10 May 2023, about 1 year ago
Updated 28 June 2023, about 1 year ago

Problem/Motivation

When viewing a page, I expect to see the page specific details on the plugin, displaying the "This page" tab on it when I click the plugin open.
However, we've run into an issue where when loading certain entity types, the plugin does not have that tab at all. Instead, it's showing the "Site summary" tab.

The pages that always give this problem are "groups", special entity made by https://www.drupal.org/project/group

We emailed to Siteimprove support the HAR files to show what exactly is happening when a page like that is loaded, and got a response that the plugin is being given is of format
https://my2.siteimprove.com/Overlay/123456789/Overview/Index?Url=xxx
while it is supposed to be of format
https://my2.siteimprove.com/Overlay/123456789/70878156528/Overview/Index?xxx&IsContentCheck=False&ContentCheckId=0

I'm trying to figure out WHY the plugin is given wrong kind of request, in order to try to get a paid developer to fix it.

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇫🇮Finland tormu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tormu
  • 🇩🇰Denmark beltofte Copenhagen 🇩🇰

    Hi Jari,

    The issue here is that we have a whitelist of route names where the Siteimprove plugin should show the "This page"-tab (method: input) and fallback to the "Site summary"-tab (method: domain) on all other routes. Right now is whitelist only including entity node and taxonomy_term routes, and not on group routes for example. We will discuss the issue with our Siteimprove contacts and get back to you.

    Best regards,
    Jens Beltofte

  • Assigned to beltofte
  • 🇩🇰Denmark beltofte Copenhagen 🇩🇰
  • @beltofte opened merge request.
  • Assigned to bartvig
  • 🇩🇰Denmark beltofte Copenhagen 🇩🇰

    Support for Group 3.1.x added in the issue fork. It includes a bit of rewrite of the code in siteimprove_toolbar() too. MR created and assigned to @bartvig.

    Notice: The MR is only tested on Group version 3.1.0 and NOT tested on earlier minor or major versions of the module. The code does not really on any API calls or similar to the Group module, but solely "white list" some menu routes and support enabling prepublish for specific Group Types. So it may work on earlier major versions of the Group Module.

    Backport: We will not backport this change to the 8.x-1.0 branch, as none of the recommended versions of Group nor the old 8.x-1.5 version supports Drupal 8 or the early minor versions of Drupal 9.

  • First commit to issue fork.
  • Status changed to Fixed about 1 year ago
  • 🇩🇰Denmark beltofte Copenhagen 🇩🇰

    Fixed. Included in today's releases.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024