Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 25 August 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇫🇷France prudloff Lille

    If anyone needs to start using this module on Drupal 10, here is a patch that applies cleanly on 2.0.0.
    (Reviewers should review the patch that targets 2.x-dev instead.)

  • Comment almost 2 years ago →
    🇫🇷France GaëlG Lille, France

    This module also includes a CKEditor plugin. If you use it, note that it's not yet compatible with CKEditor5, the version bundled in D10 core.

  • Comment almost 2 years ago →
    🇮🇳India kkalashnikov Ghaziabad, India

    update Dependency injection.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States COBadger

    I tested the patch in comment #6 📌 Automated Drupal 10 compatibility fixes Fixed against 2.x-dev and it resolved the issues that upgrade_status reports, however the ckeditor plugin throws ajax errors:

    ResponseText: Error: Non-static method Drupal\image_popup\Controller\ImagePopup::render() cannot be called statically in Drupal\image_popup\Form\EditorImagePopupDialog->submitForm() (line 261 of /app/web/modules/contrib/image_popup/src/Form/EditorImagePopupDialog.php).

  • First commit to issue fork.
  • Assigned to shivam_tiwari
  • Comment over 1 year ago →
    🇮🇳India shivam_tiwari
  • @shivam_tiwari opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India shivam_tiwari
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India sidharth_soman Bangalore

    @shivam_tiwari Your MR appears to resolve all the issues according to my upgrade status module. The only error remaining is to add the Drupal 11 version into core_version_requirement but that obviously isn't a requirement since this issue is for Drupal 10.

    However, it seems that you've applied your commit directly to the 2.x branch instead of the 3297406 issue branch. I'm guessing this probably isn't desirable.

    Moving the status to RTBC for now but let's see what the maintainers have to say about the branches and so forth.

    Attaching the screenshot of upgrade status scan for reference.

  • Comment over 1 year ago →
    🇦🇺Australia gordon Melbourne

    I have also been testing this as a part of Drupal 10 upgrade. So far everything is looking fine, and it would be great if we can get this committed so it will make it easier to test.

    Thanks.

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India JayKandari

    Thank you for all the efforts & comments on the issue.
    Merged the changes to 2.x.
    Will be releasing a new D10 compatible release.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024