\Drupal\views\Plugin\views\query\Sql::getCacheTags and getCacheMaxAge don't take into account that some entities can be NULL

Open on Drupal.org →

Created on 1 June 2016, over 8 years ago

Updated 1 March 2024, 11 months ago

Problem/Motivation

\Drupal\views\Plugin\views\query\Sql::getCacheMaxAge and \Drupal\views\Plugin\views\query\Sql::getCacheTags both assume that the result of \Drupal\views\Plugin\views\query\Sql::getAllEntities is an array of Entity objects.

However \Drupal\views\Plugin\views\query\Sql::loadEntities sets missing entities to NULL.

This results in a fatal error:

Error: Call to a member function getCacheTags() on null in Drupal\views\Plugin\views\query\Sql->getCacheTags() (line 1552 of core/modules/views/src/Plugin/views/query/Sql.php).

This manifested with a view of content revisions linked to scheduled updates.

Sample view attached

Proposed resolution

Filter out nulls in \Drupal\views\Plugin\views\query\Sql::getAllEntities
Filter out nulls in \Drupal\views\Plugin\views\cache\CachePluginBase::getRowCacheTags too

Remaining tasks

tests

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated about 7 hours ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @tim.plunkett
🇬🇧United Kingdom @damiankloip
🇺🇸United States @xjm
🇳🇱Netherlands @Lendude

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs change record
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Needs work almost 2 years ago12:57am 20 February 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

With the new service think it will need a change record.
Comment almost 2 years ago →
🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺
The patch in #39, fixed my issue avoiding crashing when the entity reference was NULL.
Comment about 1 year ago →
kieran.cott
Patch #39 has resolves this issue for me, thanks
Comment about 1 year ago →
🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺
Patch doesn't seem to apply anymore on 10.2.2
Comment about 1 year ago →
🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺
Rerolled the patch for 10.2
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
Custom Commands Failed
Comment 11 months ago →
🇮🇳India ighosh
Patch #39 has solved the issue for me. Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024