- 🇦🇺Australia gordon Melbourne
Fixed an issue in layout builder. Misused the renderRoot() method.
- Status changed to RTBC
almost 2 years ago 5:02am 17 February 2023 - 🇮🇳India arunkumark Coimbatore
The patch was applied cleanly. Also working as expected.
- First commit to issue fork.
- 🇮🇳India urvashi_vora Madhya Pradesh, India
Reviewed and Tested patch provided in #5. LGTM.
Applied successfully.
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/drupal/web/modules/contrib/address-3322797$ git apply -v 3322797-5.patch Checking patch address.tokens.inc... Applied patch address.tokens.inc cleanly.
RTBC++
Committing the changes to help the maintainers.
- @urvashi_vora opened merge request.
- last update
over 1 year ago 30 pass, 1 fail - 🇳🇿New Zealand ericgsmith
+1 for RTBC - this is a very helpful patch would love to see it committed
- 🇮🇳India arunkumark Coimbatore
I verified the patch again, working fine. The PHPUnit testing failed because of the Token module dependency was not added. I tested by using the below command after installing the Token module.
vendor/bin/phpunit -c core modules/contrib/token modules/contrib/address
+RTBC
- 🇺🇸United States SocialNicheGuru
Is this a dupe of ✨ Add token for administrative_area name Needs review ?
The patch in this issue does apply to 2.x