Inline blocks missing section delta extra data on filtered block definitions

Created on 10 March 2019, over 6 years ago
Updated 11 February 2023, over 2 years ago

Problem/Motivation

It is not possible to filter the inline blocks available for placement by the section to which a block is being added.

#2973615: Add Section delta as extra data on filtered block definitions β†’ added the section delta as $extra data on filtered block definitions for non-inline blocks. However, that patch failed to analogously add the section delta for inline blocks. The intent of #2973615 clearly was to affect all blocks (not just non-inline blocks), but that was not the end result so I categorized this as a bug report.

Proposed resolution

Add the delta for inline blocks too.

Remaining tasks

Add tests
Review patch.

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
Layout builderΒ  β†’

Last updated 1 day ago

Created by

πŸ‡ΊπŸ‡ΈUnited States jdleonard Austin, TX, USA

Live updates comments and jobs are added and updated live.
  • Blocks-Layouts

    Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    For the the tests requested in #5

  • First commit to issue fork.
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    Rebased the MR against 11.x. Still needs tests.

    The previous issue added these in LayoutBuilderTest::testLayoutBuilderChooseBlocksAlter

  • Pipeline finished with Failed
    3 months ago
    Total: 608s
    #507971
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    will give the tests a stab

  • Pipeline finished with Running
    3 months ago
    #507990
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    Extended the existing test coverage (since moved to LayoutBuilderBlocksTest)

    Also replaced a few unnecessary HTTP requests with API and accessing the manage layout url directly.

  • Pipeline finished with Success
    3 months ago
    Total: 504s
    #508002
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Sorry not super clear what are the steps to trigger this issue?

  • πŸ‡¦πŸ‡ΊAustralia acbramley
  • The Needs Review Queue Bot β†’ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

  • Pipeline finished with Success
    about 2 months ago
    Total: 1948s
    #530608
  • πŸ‡³πŸ‡ΏNew Zealand danielveza Brisbane, AU

    This makes sense to have. Done a review, code changes & test coverage look good. Happy to RTBC.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 886s
    #551451
  • Pipeline finished with Success
    about 1 month ago
    Total: 988s
    #551476
  • Pipeline finished with Failed
    about 1 month ago
    Total: 775s
    #551515
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 97s
    #551571
  • Pipeline finished with Failed
    about 1 month ago
    #551572
  • Pipeline finished with Failed
    about 1 month ago
    Total: 3724s
    #551573
  • Pipeline finished with Success
    about 1 month ago
    #554072
  • Pipeline finished with Canceled
    29 days ago
    #557055
  • Pipeline finished with Failed
    29 days ago
    #557056
  • Pipeline finished with Failed
    29 days ago
    #557069
  • Pipeline finished with Success
    29 days ago
    #557093
  • Pipeline finished with Skipped
    25 days ago
    #559965
Production build 0.71.5 2024