Inline blocks missing section delta extra data on filtered block definitions

Open on Drupal.org →

Created on 10 March 2019, about 6 years ago

Updated 11 February 2023, over 2 years ago

Problem/Motivation

It is not possible to filter the inline blocks available for placement by the section to which a block is being added.

#2973615: Add Section delta as extra data on filtered block definitions → added the section delta as $extra data on filtered block definitions for non-inline blocks. However, that patch failed to analogously add the section delta for inline blocks. The intent of #2973615 clearly was to affect all blocks (not just non-inline blocks), but that was not the end result so I categorized this as a bug report.

Proposed resolution

Add the delta for inline blocks too.

Remaining tasks

Add tests
Review patch.

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Layout builder →

Last updated 1 day ago

Maintained by
🇺🇸United States @tedbow
🇺🇸United States @dyannenova
🇺🇸United States @tim.plunkett

Created by

🇺🇸United States jdleonard Austin, TX, USA

Live updates comments and jobs are added and updated live.

Blocks-Layouts
Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

sprint

#pnx-sprint

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Incomplete comments

Sign in to follow issues

Merge Requests

!1319Inline blocks missing section delta extra data on filtered block definitions
Open
🇦🇺Australia dpi
updated 4 days ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !1319Issue #3038981: Inline blocks missing section delta extra data on filtered block definitions → (Open) created by dpi
Comment over 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

For the the tests requested in #5
First commit to issue fork.
Comment 4 days ago →
🇦🇺Australia acbramley
Rebased the MR against 11.x. Still needs tests.

The previous issue added these in LayoutBuilderTest::testLayoutBuilderChooseBlocksAlter
Pipeline finished with Failed
4 days ago
Total: 608s
#507971
Comment 4 days ago →
🇦🇺Australia acbramley
will give the tests a stab
Pipeline finished with Running
4 days ago
#507990
Comment 4 days ago →
🇦🇺Australia acbramley
Extended the existing test coverage (since moved to LayoutBuilderBlocksTest)

Also replaced a few unnecessary HTTP requests with API and accessing the manage layout url directly.
Pipeline finished with Success
4 days ago
Total: 504s
#508002

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024