- Status changed to Needs work
almost 2 years ago 9:24pm 18 January 2023 - 🇫🇮Finland lauriii Finland
It would be great if we could write some tests for this, just to make sure that this continues to work in future 😇
- 🇺🇦Ukraine voleger Ukraine, Rivne
Needs reroll as in 10.0.x branch *.es6.js files exists anymore
- Status changed to Needs review
almost 2 years ago 8:47am 20 February 2023 - Status changed to Needs work
almost 2 years ago 2:59pm 22 February 2023 - 🇺🇸United States smustgrave
Still needs test coverage so this is not ready for review yet.
- fathima.asmat London, UK
Rerolled patch 54 to resolve warning "Undefined index: title_display in template_preprocess_text_format_wrapper".
- 🇨🇦Canada mdolnik
Patch doesn't seem to apply cleanly to 9.5, so I've rerolled.
Sorry about my failing patch in #52 🐛 State required asterisk doesn't show Needs work not sure why it was not applying when I submitted it.
It seems that many of the subsequent re-rolls have introduced issues or omitted patch changes that were present in #52 that are no longer present in the latest #65.
I have provided updated patch files for D8, D9, and D10/11 (
10-1-x
currently applies to both versions).Patches
8.9.x
and9.5.x
provide the same changes.The main differences between
9.5.x
and10.1.x
:- Removes the
states.es6.js
which no longer exists. - Removes the bartik template changes as the theme no longer exists.
- Removes the classy template changes as the theme no longer exists.
- Removes the seven template changes as the theme no longer exists.
- Removes the stable template changes as the theme no longer exists.
- Alters the new claro template to be changed in the same fashion as other templates.
- Alters the new olivero template to be changed in the same fashion as other templates.
- Alters the new stable9 template to be changed in the same fashion as other templates.
- Alters the new starterkit_theme template to be changed in the same fashion as other templates.
Besides the re-rolling only a single change has been made to
states.js
which is to add the lines:// Labels within a summary. + ', details > summary'
- Removes the
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - 🇨🇦Canada mdolnik
edit: Ok \Drupal\KernelTests\Core\Theme\ConfirmClassyCopiesTest tests are failing since text-format-wrapper.html.twig got changed here which changes the hash. This patch changes Stable and Stable9. Is that allowed? I was under the impression that it wasn't... I also notice that not all text-format-wrapper.html.twig files were changed (e.g: claro, bartik, etc).
I am not sure about this, I may need someone with more knowledge as to what is allowed to be changed when it comes to base theme templates.
Regardless whether it's allowed or not, one would need to make the same changes to overridden templates in their own themes as the
title_display
variable should be provided to alltext-format-wrapper.html.twig
templates, the theme will need to ensure that the value is utilize to add theform-no-label
class or not.To clarify on these template changes, these are only to fix asterisks on formatted text widgets, so if this needs to be cut from the issue then it's not the end of the world and can be manually fixed on a site-by-site basis.