The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
+++ b/core/modules/layout_builder/src/Plugin/SectionStorage/DefaultsSectionStorage.php @@ -407,4 +409,31 @@ public function setContext($name, ComponentContextInterface $context) { + if ($bundle) { ... + }
I feel like this could be its own function, e.g.
getSectionId()
? - Status changed to Needs review
over 2 years ago 12:49pm 8 February 2023 - Status changed to Needs work
over 2 years ago 3:32pm 14 February 2023 - ๐บ๐ธUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request โ as a guide.
As a bug this will need a test case showing the issue.
- ๐ฆ๐บAustralia acbramley
Rerolled onto an MR and fixed up a few typing/code style things.
- Status changed to Needs review
about 2 months ago 2:49am 16 April 2025 - ๐ฆ๐บAustralia acbramley
Rebased, fixed some minor issues, and added test coverage.
- ๐บ๐ธUnited States smustgrave
Seems already been reviewed and feedback has been addressed. Didn't see anything additional.
- ๐ฌ๐งUnited Kingdom catch
Agreed with @kimpepper's feedback on the MR. Didn't do an in-depth review of everything.
- ๐ฆ๐บAustralia acbramley
Much nicer solution, thanks for the links. I didn't see any decisions on ๐ฑ [policy] Standardize how we implement in-memory caches Needs work with how these memory cache services should be setup wrt. service id names or how specific/generic they should be but I've loosely tried to follow what other things are doing in core already with
cache.asset_memory
andsystem.module_admin_links_memory_cache
- ๐ฆ๐บAustralia acbramley
I've tried passing the display's cache tags into the set() call so, in theory, it should be invalidated automatically when the display is saved but that doesn't seem to be the case. Must be missing something?
The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- First commit to issue fork.
- ๐ณ๐ฟNew Zealand danielveza Brisbane, AU
This has gone through multiple rounds of review, all threads have been resolved. I think it's ready to be RTBC.