Media author views filter should use the user_name plugin

Thank you for the patch in #99. It still works in Drupal core 10.2.3.

I opened a MR (in case that helps move this along) which contains the changes from #99, plus hopefully fixes the tests, although I can already see they've failed...

Made the requested changed to the MR. Unfortunately I can't do anything more to make the tests pass because the error appears to have nothing to do with the test being added here.

Just came across this and fell into the same trap as #85.
Updating IS for clarity.

- All three points mentioned by @acbramley is fixed by @maskedjellybean
- Issue summary is updated and PR is rebased with latest 11.x.
- Merge conflict is resolved.
- Hiding older patches in favour of PR based approach.
- I think it is ready for moving to needs review.

Ran test-only feature

1) Drupal\Tests\media\Functional\MediaOverviewPageTest::testMediaOverviewAuthorFilter
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "name[media_field_data.user_name]" not found.
/builds/issue/drupal-3113989/vendor/behat/mink/src/WebAssert.php:731
/builds/issue/drupal-3113989/core/tests/Drupal/Tests/UiHelperTrait.php:85
/builds/issue/drupal-3113989/core/modules/media/tests/src/Functional/MediaOverviewPageTest.php:219
FAILURES!
Tests: 2, Assertions: 58, Failures: 1.

Manually testing editing the view I'm seeing the new filters.

Believe this is good

There are no unanswered questions here.

After reading the IS I expected to see a new plugin of some type, but there isn't one. The IS says there are no UI changes but there are so there should be screenshots available from the Issue summary.

I then read the CR and saw that the screenshots are out of date. For that I applied the diff to make new ones. I then saw that the description for the new filter, 'Author name' is that it is the user ID. That is not correct, it is the user name. Should this be doing the same as the Content view and use a title of "Authored by" and a description of "The username of the content author."?

At the lest the description should change. Setting to NW.

1. Updated label and description to match /admin/content (agree with #112)
2. Updated issue summary
3. Updated screenshots
4. Updated change record

Updated 'After' screenshot to reflect change to default label

Appears to have a relevant test failure

Have not reviewed yet.

Test coverage passing now; applies a filter on username (rather than uid) and returns expected media entities as results.

Ran test-only feature

1) Drupal\Tests\media\Functional\MediaOverviewPageTest::testMediaOverviewAuthorFilter
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "name[media_field_data.user_name]" not found.
/builds/issue/drupal-3113989/vendor/behat/mink/src/WebAssert.php:731
/builds/issue/drupal-3113989/core/tests/Drupal/Tests/UiHelperTrait.php:90
/builds/issue/drupal-3113989/core/modules/media/tests/src/Functional/MediaOverviewPageTest.php:270
FAILURES!
Tests: 3, Assertions: 65, Failures: 1.
Exiting with EXIT_CODE=1

Resolved the open threads as they appears to be addressed

Applied the MR before doing an install
Followed the steps in the summary and am seeing the new filter "The username of the content author."
Applied it to the Media Library view I can filter by usernames

LGTM

Committed and pushed 68013115a83 to 11.x and c3a9311a660 to 11.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.