Add a token for publication status

Re-reading the issue summary this seems like it probably should be handled by custom module. Mentions linkit so maybe that's where it should go?

Moving PNMI as don't know where else to put it.

Re-reading the issue summary this seems like it probably should be handled by custom module. Mentions linkit so maybe that's where it should go?

Some of the other comments (17, 21) mention other contexts where it would be useful to have a token that indicates the node status: Rules ("where logic based decisions are based on token input") and content moderation notifications (though ✨ Add tokens for content moderation state Needs work will usually be more useful for folks than the published status). If there is more than one external context where this is relevant, it makes sense to put this in core: we wouldn't want to have to tell someone who's looking to use this in Rules that they need to install LinkIt!

An argument for not putting it in core is that folks might want to change the label of this output. For example, if they wanted "Unpublished" to render as a more comprehensible "Not published."

Implementing this in custom code, or in the LinkIt contrib module, is a facile change, but maybe there's an architectural rationale for putting it in core, too? The node entity is provided by core, node status (published/unpublished) is a paradigm originating in core, and the node module in core already has a number of similar tokens defined.

I've updated the issue description to better capture the community's conversation about this.

Thanks! Unfortunately I can't review it since I worked on it some. Will have to see if someone else can.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The attached patch:
1. Removes the integer-based token, since multiple commenters above cannot establish its value in core (catch in #22, alexpott in #39, acbramley in #40).
2. Updates the test coverage to explicitly look for 'Published' and 'Unpublished' text, and removes the t() usage, per #40.
3. Declares usage of FormattableMarkup to make syntax checking happy (#47).

Setting back to "Needs review"!

I can confirm the patch works. Screenshots attached.

Hm, I see not many people found the numeric token useful in comments but do we have similar tokens where we only expose a derivative textual value of the internal value in tokens and not the base value? It seems like an odd pattern to me.

+1, patch working as expected.

do we have similar tokens where we only expose a derivative textual value of the internal value in tokens and not the base value. It seems like an odd pattern to me.

Yes, a number of the tokens in node.tokens.inc do this: the "author" token returns the username rather than the UID, and the "changed" and "created" tokens return formatted dates, rather than raw timestamps.

The Linkit use case seems suffcient for adding the proposed few lines of code. Added a CR to inform folks about the new token.

Committed b23fad5 and pushed to 11.x. Thanks!

Awesome, thanks for getting that merged to 11.x !

Could we also get that change backported for 10.2 ?

10.2.x will be branched from 11.x later this year and this will be in there 😊

Automatically closed - issue fixed for 2 weeks with no activity.