- Status changed to Needs review
almost 2 years ago 2:10pm 2 February 2023 Applying the patch for the the current issue, its work alright, Please review.
- Status changed to Needs work
almost 2 years ago 2:19pm 2 February 2023 - ๐บ๐ธUnited States smustgrave
#11 still applied and without an interdiff #15 looks like a repost.
Also please read the comments and tags this needs tests which still need to happen.
Hi @smustgrave, there is a lot of changes on #15 and i verified by applied #11 patch but on that any of the tokens are not visible in available tokens list. that patch #11 is applying but not working. As i've not mention interdiff file, so attaching now...
There was a lot of messed up at above and i made little alterations in the patch path, so updating patch along with interdiff file.
- ๐บ๐ธUnited States smustgrave
Another note you can make sure your patches pass CI by
running
./core/scripts/dev/commit-code-check.sh
before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel... โ re updating the patch and and addressing CCF also attaching inter_diff along with it.
Last #21 was having some git error, updating with the new patch.
- Status changed to Needs review
over 1 year ago 3:13am 23 February 2023 - Status changed to Needs work
over 1 year ago 1:02pm 23 February 2023 - ๐บ๐ธUnited States smustgrave
Thank you for the interest but please read the tags also. This still needs tests so not ready for review
- Status changed to Needs review
over 1 year ago 11:28am 14 April 2023 - Status changed to Needs work
over 1 year ago 12:09pm 14 April 2023 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
I think this is very needed (see people stumbling without it for example in ๐ฌ Workflow Content moderation condition Closed: outdated ).
However, the direction of all the patches confuses meโ they all seem to be trying to provide standalone content moderation state tokens, when what is needed is a token on entities with content moderation enabled.
So,
[node:moderation_state]
(or likely[node:moderation_state:id]
and[node:moderation_state:label]
). The original state should be accessible on the original node token.Indeed, without any of these patches, i already have standalone Content moderation state tokens ([content_moderation_state:content_entity_id], [content_moderation_state:id] (an integerโฆ), [content_moderation_state:moderation_state:value]), they just don't work in any context relevant to me, and these patches do not seem to change that.