Policy should be added even if $route is empty, right now if $route is empty it doesn't add Referrer-Policy header
Check the headers tab Arun :)
Drupal 9 code:
=?UTF-8?B?2YXZiNmC2Lkg2KfYrtiq2KjYp9ixINiv2LHZiNio2KfZhA==?=
Drupal 10 code:
=?utf-8?Q?=3D=3Futf-8=3FQ=3F=3DD9=3D85=3DD9=3D88=3DD9=3D82=3DD8=3D?= =?utf-8?Q?B9=5F=3DD8=3DA7=3DD8=3DAE=3DD8=3DAA=3F=3D?= =?utf-8?Q??= =?utf-8?Q?=D8=A8=D8=A7=D8=B1_=D8=AF=D8=B1=D9=88=D8=A8=D8=A7=D9=84?=
@arunkumark
* Please add Tamil characters in Site Name
* Please try to install both Drupal 9 and Drupal 10 and compare the number of UTF8 characters in FROM address
Issue is that the number of characters increases drastically (with D9 we had around 79 characters and for the same text in D10 it became 358 characters.
Number of characters limitation may be environment specific but increase in characters can be reproduced. (you can check the original headers of the mail to observe this)
One reason to support stdClass explained in https://medium.com/@joshirohit100/drupal-8-custom-normalizer-c9d71c06c6e
We are supporting this today using custom normaliser, it would be great to have support in CORE.
Please release a new version 4.0.1, I see tag is already created but release is not created
https://git.drupalcode.org/project/endroid_qr_code/-/compare/4.0.0...4.0...
https://git.drupalcode.org/project/endroid_qr_code/-/compare/4.0.1...4.0...
Thanks Snadeep.
We will need tests for this so moving to needs work.
I agree, changing the validation should be based on configuration.
Thanks everyone, I would really appreciate if we can have some tests added to the patch.
I am trying to reproduce and confirm the fix and improve the solution (make it generic and work even without inline_form_errors module), I have got radios working but not able to make normal required validation work for checkboxes.
Thanks Robert for the patch, added tests to validate the solution.
https://git.drupalcode.org/project/clientside_validation/-/merge_request...
nikunjkotecha โ made their first commit to this issueโs fork.
I am sorry Selwyn, I tried with exact same steps with vanilla Drupal and PCB module but I am not able to reproduce the issue.
Is there any other customisation done around caches in your code?
Hi @sophron,
I think this should be in webform module as the file you are referring to is inside webform?
This looks like Drupal CORE issue, will try to dig a little.
nikunjkotecha โ made their first commit to this issueโs fork.
nikunjkotecha โ made their first commit to this issueโs fork.
thanks Stรฉphane for working on this
nikunjkotecha โ made their first commit to this issueโs fork.
Changing to support request as it is having conflict with another module which decorates Drupal CORE service, we can not handle all scenarios in contributed modules.
On quick look the suggested change could have a side effect, all the cache bins would be loaded using the Permanent Cache Backend and would have the function defined, this is wrong. Also this doesn't look like a production scenario, webprofiler is a developer module and supposed to be used only in development machines or non-prod environments.
Having said above I would really love to understand the use case further before closing the issue as "Works as designed". Possible to share more details around what exactly are you trying to do that causes problem for you?
Thanks Milos for reporting the issue and sharing the scenario and Patrick for the MR to fix this.
Please review the feedback and work on it and I will merge the MR + release a new version.
Sorry, I saw the message from Alberto later after merging the MR :|
@Chris Can you please update the description and status once done? I will create new release once the description is updated and no further action is required.
I don't see reason to change to something else since the library is still maintained. I see last release was in July 2022 and PRs are getting merged into it still.
https://github.com/jquery-validation/jquery-validation/releases/tag/1.19.5
For vanila JS or some another library IMO it would be best to create a new contributed module and also to look for support of validations out of the box, on quick look it seems Zod would require lot of work.
I would recommend moving forward with the solution in https://www.drupal.org/project/jquery_colorpicker/issues/3284430 ๐ Remove Dependency of vendor stream wrapper from jquery colorpicker Fixed
I ran into same issue and at first it didn't even go into VendorFileDownloadController as we are using https://www.drupal.org/project/fast_404 โ module which executs first and stops processing forward completely based on extension.
Recommended way to use public libraries is to add them via composer as drupal:library and I would recommend moving forward with the same approach.
Patch from other ticket updated with latest version and attached here.