Email validation: do not authorize email like xx@xx

Thank you for the patch. I was having issues with forms submitting with email adress just like that and triggering wierd errors on the server side. This fixed it.

I am using drupal 9.7 and php 7.4.

Hi, thanks for this usefull patch.
But what about email addresses with subdomain, like XXX@sub.domain.ext ?

We need to allow repeated segments with dots, after the @.
So, by changing the regex by the one proposed in this new patch, the validation passes for email addresses with subdomain.

Hi,

@Striknin, thanks for the patch, this is a case I am encountering on my project too.

But with this patch, xx@xx is now valid again which was the original point of the issue.

I will update the MR.

This is regex from Jquery library:

return this.optional( element ) || /^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/.test( value );

This is the new proposed one:

return this.optional( element ) || /^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)+$/.test( value );

I removed the "?" to have a first domain part. And changed the "*" to "+" to have any depth of subdomains. But with at last a first level.

xxx@xxx => FALSE
xxx@xxx.xxx => OK
xxx@xxx.xxx.xxx => OK

etc.

Uploading patch for Composer usage.

Hello,
@Grimreaper you're absolutely right! My bad, I didn't re-check after changing the regex ...
It's now perfect, thank you !

@Striknin, thanks to have re-tested.

Changing to RTBC regarding comment 9.

Would it be feasible to make the change optional? Sometimes, such as when testing in the context of a local development environment, you might validly want to just enter user@localhost.

Regards,

Nigel

I agree, changing the validation should be based on configuration.

Made the jquery over ride based on config. Please review.