🇫🇷France @Striknin

Hi,

For my own needs, I've created a patch to change the way that Webform Submissions Download → module add files to the final zip.

With encrypted files for example, we need to "call" them with their uri (not realpath on the server) and next manipulate them.
I'm not sure that is the best way to do that but it works.
See issue here : https://www.drupal.org/project/webform_all_download/issues/3432583 🐛 Zip file don't manage encrypted files Active

Striknin → created an issue.

Same here, with the module Webform Submissions Download →

Files all zipped but encrypted. So, on after unzip, files aren't readable

Striknin → created an issue.

Striknin → changed the visibility of the branch generate-file-name-3420803 to hidden.

Striknin → changed the visibility of the branch generate-file-name-3420803 to active.

Striknin → created an issue.

Thanks sidharth_soman → for the patch !

MR opened.

Striknin → created an issue.

Striknin → created an issue.

#47 💬 Conflicts with drupal/core-recommended 10.1.x-dev requires egulias/email-validator ~4.0.1 Active Works perfectly !
Simply add this require in composer.json :

"egulias/email-validator": "4.0.2 as 3.2.6"

and run :

composer update egulias/email-validator -W
composer require 'drupal/swiftmailer:^2.4' --update-with-dependencies 

#43 💬 Conflicts with drupal/core-recommended 10.1.x-dev requires egulias/email-validator ~4.0.1 Active not working on D10.1.7 (conflicts with symfony/mime v6.3.5)

Hi !

I already tried this, I doesn't work.
I tried :

• composer req drupal/hook_event_dispatcher:^4@rc
• composer require 'drupal/libraries_provider:^2.0'

And also with "--with-all-dependencies".

But, you're right ! It's due to hook_event_dispatcher. In my composer.json, I've set minimum-stability to dev and install is successfull.

Striknin → created an issue.

Striknin → created an issue.

Striknin → created an issue.

Striknin → created an issue.

It seems that the config schema doesn't make a string translatable even if "translatable: true" is specified.
So changing with label works fine.

Striknin → created an issue.

Hello,
@Grimreaper you're absolutely right! My bad, I didn't re-check after changing the regex ...
It's now perfect, thank you !

Hello,

This patch was very usefull into my project, thanks for that.
But :

The main wrapper should be a container instead of a form_element.

This allows to have inside only the fields that interest us (select and other)

All fields, should have a "#title"

But actually with patch 21, "Other" field doesn't have one if settings are empty. In case of use of "Clientside validation" or other module like this, errors can't be display with the name of the field. Instead there is a "This field field is required." for example.

Settings that we can customize (Label, name of option, placeholder) should be translatable.

This can simply be possible with the use of t() function in some places. We should maybe, make these settings translatable with the use of config translation and UI, it should be more proper.

I've created a patch, applied on tag 4.0.0 to include these modifications, I propose it in attachments (with interdiff patch).
If I can, I will post a patch that can apply on default branch (dev)

Striknin → created an issue.

Hi, thanks for this usefull patch.
But what about email addresses with subdomain, like XXX@sub.domain.ext ?

We need to allow repeated segments with dots, after the @.
So, by changing the regex by the one proposed in this new patch, the validation passes for email addresses with subdomain.