Node form layout looks awkward on wide screens since #3158854

Created on 25 November 2020, about 4 years ago
Updated 1 February 2023, about 2 years ago

Problem/Motivation

Since #3158854: Node form: address chasm between main form and meta the node form layout seems needlessly narrow and centering feels awkward on wider screens. In my opinion the "chasm" in the original issue is still not addressed, and a new chasm on the left has been introduced. Previously the form elements were left-aligned with the page title and breadcrumb which feels natural. The right sidebar is now quite narrow could make better use of the space available.

Steps to reproduce

1. Install 9.1.0-rc1 on simplytest.me and enable Claro.
2. Switch admin theme to Claro
3. Go to /node/add/page

Basic page form in 9.0

Basic page form in 9.1

Basic page form in 9.1 with toolbar docked to the left

It looks a bit better here:

Proposed resolution

To be determined

Remaining tasks

Gather additional reviews. It's entirely possible this opinion is not widely held.

User interface changes

To be determined

API changes

Probably not

Data model changes

Probably not

Release notes snippet

📌 Task
Status

Fixed

Version

9.4

Component
Claro 

Last updated about 12 hours ago

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇫🇮Finland Nchase

    ok, I have to look into howto create patches. The only viable solution is to remove the max-width entirely. Everything else doesn't work.

  • 🇨🇦Canada lindsay.wils

    Have to chime in here and say this max width makes this theme totally unusable. We setup all our node edit pages with vertical tabs to make the editing process simpler for users, keeping things in sensible groups. This destroys all that, along with using Paragraphs. Will be going back to Seven until this issue is resolved.

  • 🇺🇸United States pyrello

    It seems like maybe the solution here is to make this configurable? I can understand the desire to have this feature for new sites and better OOTB experience, but it is certainly not workable for a lot of setups using vertical tabs and/or Paragraphs.

  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Seems like there are many legitimate objections to the changes here! However, there's unfortunately zero chance of getting it addressed by commenting on an issue that was closed almost a year ago. Fortunately, if this same info is included in a new issue this moves from "zero chance" to "quite likely" that someone will work on addressing the problems reported.

  • 🇺🇸United States crutch

    The open one is marked as duplicate and there is a link chain to here after upgrading to D10 with Claro. Using vertical tabs. For D9 we overrode max-width in css. Now the thin column is back without max-width but width: min().

    We use a custom block for inline css overrides for claro admin theme for ease of adjustments.

    Used this in D9

    <style type="text/css">
    
    .layout-region--node-main .layout-region__content,
    .layout-region--node-footer .layout-region__content {
    max-width: 100%;
    
    </style>
    }

    It changed for D10

    We can't make it 100% of the area without pushing the admin tabs off canvas. 75rem seems to be okay.

    <style type="text/css">
    
    .layout-region--node-main,
    .layout-region--node-footer {
    width: min(75rem, 100%);
    
    </style>
    }

    Before in D9 it flexed well with the admin tabs at max-width 100%;

  • 🇺🇸United States alphex Atlanta, GA USA

    Crutch check out this module : https://www.drupal.org/project/asset_injector to do CSS better then a custom block, the way you're doing it.

  • 🇺🇸United States crutch

    Thanks alphex! Installed and using.

  • 🇺🇸United States crutch

    Note that the class changed for 10.3.1

    .layout-region--main,
    .layout-region--footer {
    width: calc(100% - 2rem);
    }
    
    .layout-region--main .layout-region__content,
    .layout-region--footer .layout-region__content {
    max-width: 100%;
    margin-right: auto;
    margin-left: auto;
    }
Production build 0.71.5 2024