I'd also update the requirement for the sdk.
Grayle → changed the visibility of the branch 3464645-pluginautocomplete-form-element to active.
Grayle → changed the visibility of the branch 3464645-pluginautocomplete-form-element to hidden.
There's a bug with the latest MR. The variables should be reset a loop deeper.
I do not have time to make a patch or MR, but the main block should look like this:
foreach ($text_token_aliases as $type => $text_token_alias) {
foreach ($text_token_alias as $alias => $tokens) {
// Reset the variables in this loop.
$alias_tokens_mapping = [];
$data_for_current_token = [];
$unaliased_tokens = [];
foreach ($tokens as $token => $unaliased_token_name) {
$unaliased_tokens[$token] = "[{$unaliased_token_name}]";
$alias_tokens_mapping["[{$unaliased_token_name}]"] = "{$type}{{$alias}}:$token";
}
// @todo Check if need to add else condition ?
if (isset($data["{$type}{{$alias}}"])) {
$data_for_current_token[$type] = $data["{$type}{{$alias}}"];
$replacements_unaliased = $this->generate($type, $unaliased_tokens, $data_for_current_token, $options, $bubbleable_metadata);
foreach ($replacements_unaliased as $unaliased_token_name => $value) {
$aliased_token_name = $alias_tokens_mapping[$unaliased_token_name];
$replacements["[{$aliased_token_name}]"] = $value;
}
}
}
}
Otherwise you get very weird issues. Easy way to test:
function test_token_reps() {
$data = [
'user{target}' => User::load(1),
'user{source}' => User::load(0),
'user{thirdy}' => User::load(6),
];
$text = "
Target UID: [user{target}:uid]
Target Name: [user{target}:name]
Source Name: [user{source}:name]
Thirdy UID: [user{thirdy}:uid]
Source Name: [user{source}:name]
Target Mail: [user{target}:mail]
Thirdy Mail: [user{thirdy}:mail]
";
$text = Drupal::token()->replace($text, $data);
echo $text;
}
The thing is that you can't use the same fields for all the aliases, gotta have some diffs. Then it goes haywire.
Updated the library. Removed as many specific dependencies as I could, emptied require-dev until I have time to update all those dev dependencies. Code itself now assumes PSR18 compatible client is passed, updated where needed. Actually, I might restrict this version to only D10 due to that, as I think it may now fail on D9.
https://gitlab.com/dropsolid/unomi-sdk-php/-/merge_requests/3#3957b91a0d...
Added the same check in library
https://gitlab.com/dropsolid/unomi-sdk-php/-/blob/php8/src/Http/ApiClien...
Latest release(s) uses updated library. See updates section on main page for info on the new versions.
Reroll for latest 1.1 release, I don't have time to reroll it for 2.x atm. But when I update the project I'm working on to D10 I'll come back to this, not sure when that'll be though.
I committed the minimal version, just updating the info.yml file. Don't have time to properly test the full patch with cleanup, but afaik only the info.yml is needed for actual compatibility.
Ignore this patch, it's 111's patch but with modal instead of off canvas. Speaking of, any chance this patch can be created so people can alter if it's off canvas or modal, etc. We're using https://www.drupal.org/project/layout_builder_modal → with some extras in hook_link_alter, and it's a fairly popular module.
woops
Tried patch from #92, and preliminary tests worked great.
Test Case:
Layout Override (homepage):
- add a custom block (a custom copyright block in this case)
- add language visibility, only show for English
- works great
Layout Override (homepage):
- add a reusable content block
- add language visibility, only show for English
- works great
Layout Override (homepage):
- add another instance of the above reusable content block in another section
- add language visibility, only show for Dutch
- still works great
So those use cases seem to work at least.