- Status changed to RTBC
almost 2 years ago 2:14pm 15 March 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
The approach was already validated before in #14 and I think this looks good as well, this has enough test coverage as well.
I was doubting if the hook was the right place or if we should do it where the user actually gets removed, but I think this is better so that it all sticks in the file module.
- Status changed to Needs work
over 1 year ago 9:15am 31 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
No longer applies.
Fix looks good though
+++ b/core/modules/file/tests/src/Functional/FileListingTest.php @@ -214,6 +217,57 @@ public function testFileListingUsageNoLink() { + // Create node entity and attach the created file. + $node = $this->drupalCreateNode(['type' => 'article', 'file' => $file]); + $node->save();
Why do we create a node and an entity to attach the file to?
Isn't one (the entity test entity) enough?
- First commit to issue fork.
- 🇮🇳India mohit_aghera Rajkot
I've addressed the feedback in #40
I think node tests aren't required as such.Fixed a few more things in the PR
- convert it to use OOP hooks
- Fixed a few things in tests.
- Tests seems green now.Hiding all the patches in favour of MR.