Improve JSWebAssert::waitOnAutocomplete

Created on 29 November 2016, about 8 years ago
Updated 17 October 2023, about 1 year ago

Problem/Motivation

This issue began with proposing improvements to assertions in EntityReferenceAutocompleteWidgetTest::testEntityReferenceAutocompleteWidget. That changed in #35 📌 Improve JSWebAssert::waitOnAutocomplete Needs work to improving \Drupal\FunctionalJavascriptTests\JSWebAssert::waitOnAutocomplete.

There was previously a random failure:

1) Drupal\FunctionalJavascriptTests\EntityReference\EntityReferenceAutocompleteWidgetTest::testEntityReferenceAutocompleteWidget
PHPUnit_Framework_Exception: Argument #2 (No Value) of PHPUnit_Framework_Assert::assertCount() must be a countable or traversable

/var/www/html/core/tests/Drupal/FunctionalJavascriptTests/EntityReference/EntityReferenceAutocompleteWidgetTest.php:73

This issue currently proposes to improve the assertion for future debugging.

Steps to reproduce

Proposed resolution

- Added support to check the autocomplete is opened on the correct field
- Added testing for the tags mode to increase coverage.

Remaining tasks

Reroll patch
review

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Entity reference 

Last updated 22 days ago

No maintainer
Created by

🇺🇸United States mikeryan Murphysboro, IL, USA

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024