- last update
about 1 year ago 30,412 pass - ๐บ๐ธUnited States mradcliffe USA
I added the Needs issue summary update tag because it would help to understand remaining work and the proposed resolution specifically the test coverage expansion in the issue summary rather in the comment chain.
I am working with @ompiepy at MidCamp 2024 and we're going to look at this issue to try to move it forward. Possibly transitioning to a merge request after updating the issue summary.
I am looking into the issues to get the summary update and then start working for the merge request.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Merge request !93902871217: Avoid error when $options is NULL in buildUrl() โ (Open) created by samit.310@gmail.com
- Status changed to Needs review
4 months ago 8:21am 2 September 2024 - Status changed to Needs work
4 months ago 2:23pm 3 September 2024 - ๐บ๐ธUnited States smustgrave
Did not review
Issue was tagged for issue summary update which appears to still be needed.
- ๐ฎ๐ณIndia mdsohaib4242
To handle the error when $options is NULL in buildUrl(), you can add a simple check to ensure that $options is always an array.
Something like this$options = is_array($options) ? $options : [];
- ๐ญ๐บHungary djg_tram
The patch we suggested seven years ago (!), simply casting to array, was already capable of accomplishing this. :-)
I have long moved on since and no longer bitten by this problem but this one is really ridiculous, I have to say. A very straightforward modification that obviously doesn't even require testing, it cannot cause any problems or regresssion by definition, and nobody ever bothered to accept it (or even argue against it). Must be one of the record setters in Drupalland. :-)