Awesome, thanks for committing this! I am still using the book module and I guess will be following it to contrib when I get the site to 11 so glad to see this added.
At the time I wrote this, beta9 was the latest version and, as you can see → , it is listed as D9 compatible, which it is not. I wasn't expecting you to make it D9 compatible; I was just documenting the issue on the release page. Since that is no longer the latest version, and the D9 compatibility listing has been removed from the latest version, it's likely no longer an issue but you might want to consider fixing that release, anyway, just to avoid any issues for anyone still on D9.
michelle → created an issue.
This documentation page is not an appropriate place for support questions. Please see https://www.drupal.org/supporthttps://www.drupal.org/support → for options.
---
Esta página de documentación no es un lugar apropiado para preguntas de soporte. Consulte https://www.drupal.org/supporthttps://www.drupal.org/support → para conocer las opciones.
My issue, https://www.drupal.org/project/drupal/issues/3438769 🐛 Sub workspace does not clear Closed: duplicate was marked as a duplicate of this. However, this patch is not fixing the issue of the develop workspace not clearing. Is there something not working here, or is my issue not actually a duplicate?
@amateescu,
Thanks for finding that. I did search quite a bit before filing these issues but I guess I just wasn't using the right terms. I was calling it "sub workspace" not "develop workspace". If I hit any more problems, I'll search on that.
Michelle → created an issue.
Michelle → created an issue.
Michelle → created an issue.
Added the fix to another class that needs it.
Fixed naming the file wrong...
Michelle → created an issue.
Because the properties that are being dynamically added aren't fixed and can be altered by other modules, defining them all is not possible. I added #[AllowDynamicProperties] to suppress the deprecation warnings.
Michelle → created an issue.
Patch looks good and does the job. Thanks!
I needed to remove the trailing spaces in order to make it work for us. Patch attached.
Makes sense. Thanks. :)
I attempted to port this for a client but ran into issues and haven't gotten it working, yet. This is what Upgrade Status reports is needed:
Commerce Cart Advanced
Scanned on Sun, 09/03/2023 - 18:36.
1 error found. 3 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.
web/modules/contrib/commerce_cart_advanced/src/Event/CartsSplitEvent.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check │ 12 │ Class Drupal\commerce_cart_advanced\Event\CartsSplitEvent │
│ manually │ │ extends deprecated class │
│ │ │ Symfony\Component\EventDispatcher\Event: since Symfony 4.3, │
│ │ │ use "Symfony\Contracts\EventDispatcher\Event" instead │
│ │ │ │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘
web/modules/contrib/commerce_cart_advanced/src/Hook/CartItemFormAlter.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 77 │ Parameter $number_formatter_factory of method │
│ manually │ │ Drupal\commerce_cart_advanced\Hook\CartItemFormAlter::__cons │
│ │ │ truct() has typehint with deprecated interface │
│ │ │ Drupal\commerce_price\NumberFormatterFactoryInterface: │
│ │ │ Replaced by CurrencyFormatterInterface. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
web/modules/contrib/commerce_cart_advanced/src/Plugin/Block/CurrentCartBlock.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 67 │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector │ │ drupal:9.3.0 and is removed from drupal:10.0.0. Use │
│ │ │ Drupal\Core\Extension\ExtensionPathResolver::getPath() │
│ │ │ instead. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
web/modules/contrib/commerce_cart_advanced/commerce_cart_advanced.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8.7.7 || ^9 is not │
│ manually │ │ compatible with the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴────────────────────────────────────────────────────────────┘Here's the patch.
Michelle → created an issue.
This patch doesn't apply anymore. When I grabbed the git version so I could re-roll it, I found that the changes (except the comment) are already in there. I guess this can be closed? Unless you want to re-roll just to fix the comment.
Turns out I wasn't seeing the entire error on my local for some reason. A coworker tried my branch and also got
The package drupal/ckeditor in require is also listed in provide which satisfies the requirement. Remove it from provide if you wish to install it.
in addition to the unhelpful error I got about it not being in the lock file. So all that was needed was to remove that bit.
@Thomas Kaisuka Thanks but if it were that simple I wouldn't have filed an issue. I've been doing Drupal for 18 years and know how to enable modules. :) The problem is that the system is not recognizing the contrib module because it has the same machine name as the core one. It won't let me enable it in drush and doesn't appear in the UI at all. On three other projects it's just worked automatically so I don't know what is different about this one. I'm temporarily off that project but will be back at it in a couple weeks and will check and see if it automagically worked like the others while I was gone.
Michelle → created an issue.
I deleted the spam change but it didn't restore the title and I don't know what it was before so just getting the spam out of it.
Thanks, that other ticket looks useful. I'll dig into that one once the client prioritizes this again. It would be nice to have a more stable solution than the hack-around I did.
Michelle → created an issue.
Somehow the patch lost the ['pages'] that was in my local so putting that back in.
Here's the patch.
Michelle → created an issue.
I have been trying to use some of my contrib time to test this patch but I can't reproduce the problem. I don't know why the patch was on the client site so I can't test it there and I can't reproduce this in a fresh D7 install. I've tried both the repro steps and also following along with the original report and both times all the nodes show up whether I am logged in or not.
Hopefully someone who is having this problem can confirm your patch works. All I can confirm is that it didn't cause any visible problems on the client site when I tested it there.
@ChristianAdamski: Looking at the diff between #231 and #269 I see that, in addition to the added test, this part was removed. Was that intentional?
- $tables = $query->getTables();
+ $tables = &$query->getTables();
Changing the version/status to test that last patch.
I think this might help my use case as well. I run the website for the camera club I am in and we maintain the "roster" via user accounts. This works great except for those who don't have email addresses (mostly the older ones). I currently put in a fake email for them but having them be users without accounts would be much cleaner, I think.
Michelle