🇸🇪Sweden @marcusml

Wops! I noticed I had access to the merge button myself so I tried and it worked. 🙈

https://git.drupalcode.org/project/lionbridge_translation_provider/-/com...

marcusml → created an issue.

Hmm, that error message wasn't very helpful. Could you try again? :D

I don't know if this could be of any help but here's documentation on drupal.org on how MRs are supposed to be merged. https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine... →

If we're not able to merge it I can cherry-pick the commit and push to 8.x-2.x if that's ok with you? Let me know.

marcusml → created an issue.

This makes it more difficult for sites to comply with GDPR as it can be difficult to remove unlawful personal data.

Well this depends on how you look at it. If we consider revisions as a backup, then everything is fine. We only have to ensure that the revisions cannot be accessed. If you still want to delete a specific translation from all revisions, then this is still possible even with the current issue:

$entity_type_id = 'xyz';
$entity_id = 1092;
$remove_translation_langcode = 'abc';
$entity_type_manager = \Drupal::entityTypeManager();
$entity_type = $entity_type_manager->getDefinition($entity_type_id);
$storage = $entity_type_manager->getStorage($entity_type_id);
$revisions = $storage->getQuery()
  ->condition($entity_type->getKey('id'), $entity_id)
  ->condition($entity_type->getKey('langcode'), $remove_translation_langcode)
  ->allRevisions()
  ->execute();
foreach (array_keys($revisions) as $revision_id) {
  $revision = $storage->loadRevision($revision_id);
  $revision->removeTranslation($remove_translation_langcode);
  $revision->save();
} 

This doesn't seem to be true (anymore at least). I'm currently trying to clean up translations from old revisions. Removing a translation from a revision and calling save() on it results in a new revision being created with the translation removed. Instead of the translation being removed from the loaded revision.

I haven't yet found a way in which the Entity API allows me to remove a translation from a revision. Setting $revision->setNewRevision(FALSE); doesn't make it work either.

marcusml → created an issue.

I've added tests and rebased the current work.

I ran into this issue when saving a layout override with an inline block from the layout library which I included a test for as well.

marcusml → made their first commit to this issue’s fork.

Restoring issue summary, tags and related issue which was removed in #68.

marcusml → created an issue.

Hi @Juan.OrtizMenchaca! What's the reason for closing this? Are we not doing a Drupal 10 release? 👀