The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 4:17am 11 July 2023 - last update
over 1 year ago 29,806 pass - 🇮🇳India gauravvvv Delhi, India
Re-rolled patch #70, Also added few missing files, add updated CSS files. Not adding interdiff as patch #70, no longer applies to D11. please review
- Status changed to RTBC
over 1 year ago 1:56pm 13 July 2023 - 🇺🇸United States smustgrave
Think this is good (if something we still want to do)
Searched the repo for "form-checkboxes" and didn't find anything using that specific class.
- last update
over 1 year ago 29,811 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,822 pass - last update
over 1 year ago 29,842 pass - last update
over 1 year ago 29,878 pass - last update
over 1 year ago 29,876 pass, 1 fail The last submitted patch, 82: 2407723-82.patch, failed testing. View results →
- last update
over 1 year ago 29,881 pass - First commit to issue fork.
- Status changed to Needs work
12 months ago 11:46am 29 November 2023 - Merge request !5589Resolve #3303544 "Remove classes from system templates" → (Closed) created by vsujeetkumar
- Status changed to Needs review
12 months ago 12:04pm 29 November 2023 - 🇮🇳India vsujeetkumar Delhi
Re-roll & Convert Patch #82 into MR. Please have a look.
- Status changed to RTBC
12 months ago 2:02pm 29 November 2023 - Status changed to Needs review
10 months ago 8:33am 24 January 2024 - 🇳🇿New Zealand quietone
Sorry, but this needs a review of the change record. It was added in 2015 and does not mention classes being removed. Is it correct?
- Status changed to Needs work
10 months ago 4:26pm 25 January 2024 - Status changed to Closed: outdated
7 months ago 8:06pm 2 May 2024 - 🇺🇸United States bnjmnm Ann Arbor, MI
This was filed ~10 months before Drupal 8 was released, any time during those 10 months would have been a fine time to take care of this.
Drupal 8+ has now been around for 8.5 years, and removing the classes now would be incredibly disruptive and cause many regressions. The intentions here were good, but any benefits they'd have yeilded are trival compared to the problems that would be introduced. Closing so nobody winds up devoting any more time to something that I (Frontend Framework Manager) would not approve.