Load user entity in Cookie AuthenticationProvider instead of using manual queries

Rerolled the patch #137 in Drupal 10.1.x.

Rerolled patch #138, please review it.

Fixing custom commands failure issues in patch #140, please review it.

The last submitted patch, 143: 2345611-143.patch, failed testing. View results →

Re-roll #137 for D10.0.x

Needs a reroll for 11.x-dev. I'll stick around for reviews here. Find me in the sky lounge at DDD vienna if there are any questions.

Also desperately needs an issue summary update.

Issue summary: done.

1. +++ b/core/lib/Drupal/Core/Entity/ContentEntityBase.php
   @@ -618,6 +618,58 @@ protected function getTranslatedField($name, $langcode) {
   +   * Only the first delta can be accessed with this method.
   

   This is not true. There is an optional $delta argument.

2. +++ b/core/lib/Drupal/Core/Entity/ContentEntityBase.php
   @@ -618,6 +618,58 @@ protected function getTranslatedField($name, $langcode) {
   +  public function getFieldValue($field_name, $property, $delta = 0) {
   

   Let's add type hints here.

Rerolled for 11.x as mentioned in #147.
Tried to address pointer 2 in #151.

This is not true. There is an optional $delta argument.

In #151.1, True $delta argument is optional, As per my understanding, Either we should update the comment like

By default the first delta can be accessed with this method.

or we can remove this line from the comment.

These are two of very few database queries executed on an authenticated page request when dynamic page cache is a cache hit, if we load the user it will usually come from the cache.
See for example https://grafana.prod.cluster.tag1.io/explore?panes=%7B%22taO%22:%7B%22datasource%22:%22tempo%22,%22queries%22:%5B%7B%22query%22:%2269f4dbd9a3acdf0e49e11acc90cbae81%22,%22queryType%22:%22traceql%22,%22refId%22:%22A%22,%22datasource%22:%7B%22type%22:%22tempo%22,%22uid%22:%22tempo%22%7D,%22limit%22:20%7D%5D,%22range%22:%7B%22from%22:%22now-6h%22,%22to%22:%22now%22%7D%7D%7D&schemaVersion=1&orgId=1 this trace from the Umami authenticated performance test. Would only be a small optimization from that perspective but worth doing I think, so tagging with performance for that.