Refactor Claro's details stylesheet

Per our slack conversation a few weeks ago @ckrina moving these to postponed for I believe a followup on the game plan

This is my first Patch. Just checking for encoding errors.

You can check for build errors by running ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel... →

Also would check how other tickets were done for this as far as updating with logical properties and nesting.

I have updated the file with the CSS logical properties. I have attached a patch for same. please review

LGTM !

The last submitted patch, 12: 3303544-12.patch, failed testing. View results →

Unrelated failure, restoring status.

Patch for V11

The last submitted patch, 17: 3303544-17.patch, failed testing. View results →

#17 shows unrelated JS failure.

#12 Patch is working for D11. LGTM !

Restoring Status, ready to be merged.

The last submitted patch, 17: 3303544-17.patch, failed testing. View results →

Patch #12, is still passing all the tests. Restoring status, random failure
@Stanzin, Please add interdiff for #17

1. +++ b/core/themes/claro/css/components/details.pcss.css
   @@ -141,24 +131,19 @@
   -[dir="rtl"] .claro-details__summary::before {
   ...
   -  transform: rotate(-270deg);
   

   This style should be added back

2. We should move details related variables from variables.pcss.css to details.pcss.css

Tried to address 1 mentioned in #22.

Addressed feedback #2, from #22 and feedback #1, from #22, is already addressed in patch #12. I have mentioned in comment #21 that patch #17 is not needed, patch #12 still applies cleanly. I have attached interdiff with #12, for moving detail variables from variable.pcss.css to details.pcss.css

The last submitted patch, 24: 3303544-24.patch, failed testing. View results →

Indent for new variables in details.pcss.css is off.

Also with the additional changes could use a new set of before/after screenshots

Thanks.

working on it

In this Patch addressing the comment #27,
attaching interdiff file.

Testing stepps
1.Install drupal 11.x.
2.navigate to /admin/structure/types/add

Before

After

The last submitted patch, 29: 303544-29.patch, failed testing. View results →

Appears to be random

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Convert Patch #29 into MR. According to #33. Please have a look.

@vsujeetkumar MR#36 looks fine and applied successfully. Just a simple reroll into MR Moving this to RTBC.
Thanks !

Gonna check nightwatch failure

Nightwatch issue is gone after rebase. It was something random.

I reverted variables back to variables file. Because at least half of them used in few files. And removed one which not used anywhere.

Added few minor improvements.
Please review.

Gotta love night watch haha

Committed d8e3d8c and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.