The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
over 1 year ago Patch Failed to Apply - Status changed to Needs review
over 1 year ago 9:41am 26 October 2023 - last update
over 1 year ago 30,435 pass - Status changed to Needs work
over 1 year ago 12:09pm 26 October 2023 - 🇺🇸United States smustgrave
This will need test coverage. Why is the one test being removed?
- First commit to issue fork.
- Merge request !11615Issue #2877924: Make node aware of the latest_version route → (Open) created by acbramley
- 🇦🇺Australia acbramley
The test that was removed was specifically testing the CM preprocessor which was removed so the test was no longer needed. Instead I've repurposed it to test the node_is_page function.
I was in 2 minds about doing this or 📌 Deprecate node_is_page and move into a service Active first but this might be easier to get in first.
- 🇦🇺Australia acbramley
Alternatively if we make it a service I guess CM could decorate it to add the condition to its own route 🤔
- 🇺🇸United States smustgrave
Can we update the issue summary to reflect the new scope and findings please.
Hiding patches
- 🇦🇺Australia acbramley
@smustgrave what exactly is missing from the IS? It explains exactly what we're doing?