- Issue created by @n.ghunaim
- last update
over 1 year ago 1 pass - Status changed to Needs review
over 1 year ago 12:32pm 18 July 2023 - ๐ฎ๐ณIndia keshavv India
keshav.k โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.3 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @keshavk opened merge request.
- last update
over 1 year ago 1 pass - ๐ฎ๐ณIndia keshavv India
#2 Patch fails to apply and it will also not work because It adds
isset()
method to check but the variable is already there so we need!empty
instead.
I have created the MR please review it. - ๐ฎ๐ณIndia ayush.pandey
I have updated the PHP version to 8.1 and the module Image Resize Filter to version: 8.x-1.1, and i am able to reproduce the issue.
The changes in the patch attached don't apply. The MR attached in #6 ๐ is_file(): Passing null to parameter #1 ($filename) of type string is deprecated in modules/contrib/image_resize_filter/image_resize_filter.module Needs review changes seems to work fine.
Before โ
After MR changes โ - last update
11 months ago 1 pass