- Status changed to Needs review
2 days ago 1:55pm 30 June 2024 - π©πͺGermany tstoeckler Essen, Germany
After talking to @rnsrk abou this in Burgas, spent some more time on this.
Fixed the issue mentioned in #9. Also added some inline comments about the changes and finally added some test coverage. I pushed those to individual commits in case there are any objections to any of those.
Note that I thought a bit about how to avoid all this array madness (i.e.
array_values(array_unique(array_filter(...)))
and friends) and I think the solution would be to makeDefaultTableMapping
provide anaddFields()
method, which would internally check for duplicate fields. Will open a follow-up about that, so we can avoid that discussion here (even though it does make the situation (inherently) slightly worse).Not exactly why this was tagged "Needs change record" or what the change record should be. I mean we could literally write a change notice with "Content entities may now use the same field for the ID and UUID keys" if people think that's useful. (I don't, in particular, but it also doesn't hurt, so I wouldn't mind it.)
- π©πͺGermany tstoeckler Essen, Germany
Not sure why the testbot doesn't run for the updated commits, but I opened π Replace DefaultTableMapping::setFieldNames() with ::add*() and ::remove*() Active in the meantime.
- π©πͺGermany tstoeckler Essen, Germany
...ahh maybe because the MR is targeting 10.1.x. @bradjones1 do you have access to change the target branch? Or should we create a new MR? Not sure...
- πΊπΈUnited States bradjones1 Digital Nomad Life
MR target changed.
- πΊπΈUnited States bradjones1 Digital Nomad Life
Needed a rebase and now GitLab CI is running.
- πΊπΈUnited States bradjones1 Digital Nomad Life
Added a basic CR. Tests green now.
- π©πͺGermany tstoeckler Essen, Germany
Awesome, thanks. You dropped my commits from the MR, though, I'm guessing that was accidental? π€
- πΊπΈUnited States bradjones1 Digital Nomad Life
That is so strange, I think something weird happened with changing the merge target. I thought it was strange I didn't need to do a rebase --onto... and clearly that would be necessary. I've fixed this. Thanks for catching it.