This came up in 🐛 Cannot use UUID as entity ID Needs review .
DefaultTableMapping currently needs to combine a bunch of actual "business logic" which determines which field columns go in to which entity table with a bunch of manual array jumbling (diffing/"value"ing/merging/...).
This makes the code less readable than it could be.
-
Replace DefaultTableMapping::setFieldNames() DefaultTableMapping::addFieldNames() and DefaultTableMapping::removeFieldNames().
DefaultTableMapping::addFieldNames() then internally does the "merge -> unique -> value" dance. This allows simplifiying some of the actual business logic. Note that this is never used in any runtime-critical code path so the additional cost incurred by those operations is negligible.
The latter is introduced to bring parity with the current API. It is only used in test code right now, but let's discuss it's future in 📌 Convert DefaultTableMapping::setFieldNames() and ::setExtraColumns() to protected methods Active which was opened for that exact discussion.
-
-
-
Needs review
11.0 🔥
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
Opened a merge request with the change. This will need to be changed to deprecate setFieldNames() before it can go in, but I would like some discussion/agreement that this makes sense first, before going ahead with that. Thus, marking "Needs review".