Created on 1 July 2024, 6 months ago
Updated 18 July 2024, 5 months ago

Problem/Motivation

The module only support Drupal 9 and 10.

Proposed resolution

  • Create a new version 2.x that keeps Drupal 9 and Drupal 10 support and adds support for Drupal 11
  • Create a new release 3.x that drops Drupal 9 support, keeps Drupal 10 and adds Drupal 11 support

Remaining tasks

All of the above

๐Ÿ’ฌ Support request
Status

Needs work

Version

2.0

Component

Code

Created by

๐Ÿ‡ซ๐Ÿ‡ทFrance CurriedN

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @CurriedN
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia samit.310@gmail.com

    samit.310@gmail.com โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Canceled
    5 months ago
    #224604
  • Merge request !43458252: Drupal, 11 support โ†’ (Open) created by samit.310@gmail.com
  • Pipeline finished with Canceled
    5 months ago
    #224619
  • Pipeline finished with Canceled
    5 months ago
    #224624
  • Pipeline finished with Failed
    5 months ago
    Total: 42s
    #224627
  • Pipeline finished with Failed
    5 months ago
    #224628
  • Pipeline finished with Failed
    5 months ago
    Total: 157s
    #224635
  • Pipeline finished with Failed
    5 months ago
    Total: 147s
    #224640
  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia samit.310@gmail.com

    Only one phpunit test case is failing,
    https://git.drupalcode.org/issue/images_optimizer-3458252/-/jobs/2122230

    Thanks
    Samit K.

  • ๐Ÿ‡ซ๐Ÿ‡ทFrance CurriedN
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance CurriedN

    Hello,

    First of all thanks!
    I see there is a lot of work that is not related to Drupal 11 support (ci changed, php usage changes (like removing list())). Those will be changes that can be done in other commits, would you split the commits into commits that show the intention behind? One for the support, one for the ci, one for ...
    Also, I updated the issue. We should have a new version 2.x that keep supporting D9, D10 and add D11, and a new release 3.x supporting D10 and D11.

    Second, this issue is assigned to me because it's a new release to create. This means we're not targeting 2.x but a non existant (yet) branch.

    We don't use (yet) Drupal's CI and until we chose what to use from it, it should remain that way. Or at least explain your choices :)

    Also tests/quality gates don't pass, since you added more things for checking at least we should keep everything green :)

    We have lots of things to do. I let you change your MR, split the changes into smaller commits and make it green so we can clearly review it.

Production build 0.71.5 2024