- Issue created by @CurriedN
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Status changed to Needs work
about 2 months ago 8:17am 16 July 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
Only one phpunit test case is failing,
https://git.drupalcode.org/issue/images_optimizer-3458252/-/jobs/2122230Thanks
Samit K. - ๐ซ๐ทFrance CurriedN
Hello,
First of all thanks!
I see there is a lot of work that is not related to Drupal 11 support (ci changed, php usage changes (like removinglist()
)). Those will be changes that can be done in other commits, would you split the commits into commits that show the intention behind? One for the support, one for the ci, one for ...
Also, I updated the issue. We should have a new version 2.x that keep supporting D9, D10 and add D11, and a new release 3.x supporting D10 and D11.Second, this issue is assigned to me because it's a new release to create. This means we're not targeting 2.x but a non existant (yet) branch.
We don't use (yet) Drupal's CI and until we chose what to use from it, it should remain that way. Or at least explain your choices :)
Also tests/quality gates don't pass, since you added more things for checking at least we should keep everything green :)
We have lots of things to do. I let you change your MR, split the changes into smaller commits and make it green so we can clearly review it.