🇷🇴Romania @reszli

The DNT (Do Not Track) specification has been discontinued. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/DNT or https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack

pameeela → credited reszli → .

we ran into this issue as well, with a list<string> on a user profile form
and we found the following workaround:

$language_manager = \Drupal::languageManager();
$current_language = $language_manager->getConfigOverrideLanguage();

$language_manager->setConfigOverrideLanguage($current_language);
$field_storage = \Drupal::entityTypeManager()
  ->getStorage('field_storage_config')
  ->loadUnchanged('user.[FIELD_NAME]'');
$allowed_values = $field_storage->getSetting('allowed_values');

// Do your things here.
// ... i.e. overriding the widget options in the user form
$form['[FIELD_NAME]'']['widget']['#options'] = $allowed_values;

// Revert to the original language. <== not needed in our case
// $language_manager->setConfigOverrideLanguage($current_language); 

or this is how it would look like in case of a node field:

$language_manager = \Drupal::languageManager();
$current_language = $language_manager->getConfigOverrideLanguage();

// Load translated allowed values for the field by overriding config
// language temporary.
$language_manager->setConfigOverrideLanguage($node->language());
$field_storage = \Drupal::entityTypeManager()
  ->getStorage('field_storage_config')
  ->loadUnchanged('node.[FIELD_NAME]');
$allowed_values = $field_storage->getSetting('allowed_values');

// Do your things here.
...

// Revert to the original language.
$language_manager->setConfigOverrideLanguage($current_language); 

provided MR with a change to use a class instead of the href or attribute
since for an editor, adding a class can be more straintforward than adding an attribute

reszli → created an issue.

MR6 did the trick for me!

indeed, I ran into this issue on a project where node module is not enabled.

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "node_type" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of /var/www/html/docroot/core/lib/Drupal/Core/Entity/EntityTypeManager.php).

FYI for anyone endig up here:
there is built-in alternative in D10
https://www.drupal.org/project/drupal/issues/2921810 🐛 Allow TimestampFormatter to show as a fully cacheable time difference with JS Fixed

FYI for anyone endig up here:
there is built-in alternative in D10
https://www.drupal.org/project/drupal/issues/2921810 🐛 Allow TimestampFormatter to show as a fully cacheable time difference with JS Fixed

reszli → created an issue.

the error turns out to be an issue only when webform.config.yml is not imported (so I guess it could not fall back to the defaults)

still, IMHO it would be cleaner to take over default values on form creation instead of showing empty options

reszli → created an issue.

apprently "- All -" gets translated to "- Alle -" before the replacement happens

quick workaround (or maybe even intended behaviour?) is to rewrite the translated value in the original or translated BEF configuration

Part of 2.1.0 release.

reszli → created an issue.

reszli → created an issue.

reszli → created an issue.

created an MR with the changes, also getting rid of the jquery/once in favour of core/once

reszli → made their first commit to this issue’s fork.

apparently you can't toggle the categories with the keyboard (space) anymore
maybe related to 🐛 Remove overflow:hidden rule for body when popup is rendered Fixed since now space is scrolling the page instead

cookie_content_blocker patches needs to be updated to include:
* 🐛 cookies is not defined Fixed
* 🐛 Replace jquery/once by core/once Fixed

OR hopefully there will be a new releas soon to include all those

reszli → created an issue.

replace jquery.once usages by core/once usages

we don't need the following statement:

use Drupal\Core\StringTranslation\StringTranslationTrait;

also applied similar fix to 2.0.x branch

thanks for the contribution!

reszli → made their first commit to this issue’s fork.

part of 2.1.0 release

thanks for the contribution
part of 2.1.0 release

reszli → created an issue.

reszli → made their first commit to this issue’s fork.

- switched issue to 2.x-dev
- created MR
- extended code to handle footer the same way

yes, I can still reproduce this with D10, views_show_more 2.0.0 and a views block in layout builder
but it can be fixed by setting the correct "Content jquery selector" under "Advanced Options"

$query->get('f') will not work anymore since it's not a scalar value but an array
I used $query->all()['f'] ?? [] instead

problem with this approach is that you can't even intentionally reset the filter to "any" since then the value is not in the URL and it will force the default

reszli → made their first commit to this issue’s fork.

Notes:
how I worked on this:

• set up a new "demo" project with composer create-project dropsolid/rocketship:^10.0 PROJECTNAME --no-dev --no-interaction
• install the project, to have a working D9.4 site
• add and install Upgrade Status module
• check report
• go over each module in the require section of the composer.json of rocketship_core and update to D10 compatible version, where needed

Done:

• "drupal/advagg": "^5.0" => "^6.0" and removed 2 outdated patches
• "drupal/config_filter": "^1.5" => "^2.4"
• "drupal/config_split": "^1.5" => "^2.0"
• "drupal/config_update": "^1.7" => "^2.0"
• "drupal/ctools": "^3.0" => "^4.0"
• "drupal/focal_point": "^1.5" => "^2.0"
• "drupal/google_tag": "^1.4" => "^2.0"
• "drupal/inline_entity_form": "^1.0" => "^2.0"
• "drupal/manage_display": "^2.0" => "^3.0"
• "drupal/scheduler": "^1.3" => "^2.0"
• "drupal/ckeditor" was removed
• "drupal/field_limiter" had to switch to dev release from fork
• "drupal/node_title_help_text" had to switch to dev release
• some other minor version updates, just for the sake of using latest versions

Todo:

• Check release notes for every major upgrade, update default configs and code usages where needed

reszli → made their first commit to this issue’s fork.

Notes:
how I worked on this:

• set up a new "demo" project with composer create-project dropsolid/rocketship:^10.0 PROJECTNAME --no-dev --no-interaction
• install the project, to have a working D9.4 site
• add and install Upgrade Status module
• check report
• go over each module in the require section of the composer.json of dropsolid_rocketship_profile and update to D10 compatible version, where needed

Done:

• "drupal/captcha": "^1.10 || ^2.0" was needed for combined D9 & D10 support
• "drupal/geocoder": "^3.34 || ^4.9" was needed for combined D9 & D10 support
• some other minor version updates, just for the sake of using latest versions

Todo:

• drupal/field_hidden → module does not have a D10 compatible release, nor a 2.x dev release to create MRs against - I tried to contact the maintainers

reszli → made their first commit to this issue’s fork.

reszli → made their first commit to this issue’s fork.

reszli → made their first commit to this issue’s fork.

reszli → made their first commit to this issue’s fork.

reszli → made their first commit to this issue’s fork.

I ran into the same problem today.
In my case the reason was that the field referenced by the formatter was removed.

reszli → created an issue.

as far as I can tell, this patch is not needed anymore after version 2.1.1

The buttons are actually focusable, just lacks some style to make that visible.

But at the same time, some improvements were indeed needed in terms of a11y:

• clicking any button, including "manag cookies", moved focus behind the popup - so I created separate buttons for manage / save preferences and move focus to first category switch when selecting "manage cookie"
• when category wrapper is revealed, tabindex on inputs is set to 0 - so I forced them back to -1 since we use the labels instead
• after tabbing through all categories it would make sense to have the "save preferences" button first - so I moved that to the top

reszli → created an issue.

Part of 1.0.6 release.

At the same time, I also simplified the layout of the buttons in order to empasize they are all equally important:

• always keep them one below the other
• have them take up the full width to accomodate longer button copy
• reduce the width of the popup and the font size of the H2 in the intro

reszli → created an issue. See original summary → .

In my case, it was not possible to achive Multi-byte UTF-8 support on the server, so I needed to work around it
My solution was to replace the original YouTube provider with a custom one that extends the original one and strips non-ASCII characters form the filename on preSave() method.

add these hook implementations to mymodule.module file

/**
 * Implements hook_media_internet_providers_alter().
 */
function mymodule_media_media_internet_providers_alter(&$providers) {
  unset($providers['MediaInternetYouTubeHandler']);
}

/**
 * Implements hook_media_internet_providers().
 */
function mymodule_media_media_internet_providers() {
  return [
    'MymoduleMediaInternetYouTubeHandler' => [
      'title' => t('YouTube'),
      'module' => 'mymodule',
      'weight' => 3,
    ],
  ];
}

create a new file under mymodule/includes/MymoduleMediaInternetYouTubeHandler.inc with the following content:

/**
 * @file
 * Extends the MediaInternetYouTubeHandler class to handle YouTube videos.
 */

/**
 * Implementation of MediaInternetBaseHandler.
 *
 * @see hook_media_internet_providers().
 */
class MymoduleMediaInternetYouTubeHandler extends MediaInternetYouTubeHandler {

  /**
   * Before the file has been saved, implementors may do additional operations.
   *
   * @param object $file_obj
   */
  public function preSave(&$file_obj) {
    parent::preSave($file_obj);
    // Remove non-ASCII characters from the filename.
    $file_obj->filename = trim(preg_replace('/[^\x20-\x7E]/','', $file_obj->filename));
  }

}

I can confirm the patch solved the issue for me

I can confirm this can be considered a duplicate of 🐛 Anonymous users shown empty webform without explanation Fixed and the patch there solved the issue for me

we recently changed the default categories that ship with the module: ✨ Standardise default categories and category names Fixed
also, there is a new request to change the intro text and button labels to be more in line with GDPR requirements: ✨ New text for the cookie modal & buttons Fixed
it's better to do that first, before re-rolling the changes in this ticket

reszli → created an issue.

Released in 1.0.4

reszli → made their first commit to this issue’s fork.

Part of 2.0.2 release.

Part of 2.0.2 release.

Part of 2.0.2 release.

Part of 1.0.2 release.

Part of 1.0.2 release.

Part of 1.0.3 release.

project page and readme were recently updated with more information
feel free to (re)open MR againt 2.x, if you have something relevant to add

this is related to ✨ Improve dataLayer events Fixed

I'm wondering if this is still relevant after those improvements

if so, could you please create an MR against 2.x

Probably a better approach would be to use the configuration from eu_cookie_compliance and only include this script when that one is also included.
The benefit would be that it's configurable via the UI insteaf of being hard-coded.

this was done for D8/9/10
it still needs to be done for D7 in 🐛 The GTM field added to categories does not allow empty values Needs work

this was actually solved in a duplicate ticket for D8/9/10, see ✨ Allow empty JSON data Fixed
still needs to happen for D7, so changing version

reszli → created an issue.

reszli → created an issue.

reszli → created an issue.

reszli → created an issue.

released in 8.x-1.6

merged into 8.x-1.x

I have fixed the PHPCS, PHPstan and licensing issues mentioned above in branch 2.x

regarding the PHPstan error about the invalid type CookieCategory: I guess that is a false-positve when not tested in proper context
however, I did rename the variable from $menu to $category which is more relevant

reszli → created an issue.

reszli → created an issue.

@mohit_aghera I'm proposing to cache the list of entity labels used to run the search on (and not caching the search results themselves)

https://git.drupalcode.org/project/fuzzy_entity_reference/-/blob/1.0.x/s..., lines 57-82, aka. the $matches variable calculation could be cached until new labels are added / existing ones are updated