[2.x] EU Cookie Compliance GTM

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Since these applications are for giving a Drupal role to users who apply, the fact the project is already covered by the security advisory is irrelevant.

What we need is a project where the user who applies has done commit in at least a branch, and those commits must be the only ones done, or the majority. In this case, there are some commits by other users, but the majority is done by reszli.

The application follows the usual path.

Fix PHPCS issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml eu_cookie_compliance_gtm/

FILE: eu_cookie_compliance_gtm/eu_cookie_compliance_gtm.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 8 | WARNING | All dependencies must be prefixed with the project name, for     
   |         | example "drupal:"
 9 | WARNING | All dependencies must be prefixed with the project name, for     
   |         | example "drupal:"
--------------------------------------------------------------------------------


FILE: eu_cookie_compliance_gtm/eu_cookie_compliance_gtm.module
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
 50 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced   
    |         |     with use statements
 53 | ERROR   | [x] Short array syntax must be used to define arrays
 61 | WARNING | [x] A comma should follow the last multiline array item. Found: 
    |         |     '{"analytics": "@status", "functional":
    |         |     "@functional_status"}'
 65 | WARNING | [x] A comma should follow the last multiline array item. Found: 
    |         |     ]
 71 | ERROR   | [x] Missing function doc comment
 74 | ERROR   | [x] Whitespace found at end of line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: eu_cookie_compliance_gtm/README.md        
------------------------------------------------------------------------        
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------        
  4 | WARNING | [ ] Line exceeds 80 characters; contains 124 characters
  6 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
 18 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
 23 | WARNING | [ ] Line exceeds 80 characters; contains 146 characters
 28 | ERROR   | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------        
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

PHPSTAN issues:

php vendor/bin/phpstan analyse modules/contrib/eu_cookie_compliance_gtm

 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   eu_cookie_compliance_gtm.module                                                                                                                   
 ------ -----------------------------------------------------
  87     Parameter $menu of function eu_cookie_compliance_gtm_category_form_builder() has invalid type Drupal\eu_cookie_compliance\Entity\CookieCategory.  
 ------ ----------------------------------------------------

 ------ ------------------------------------------------------
  Line   tests/src/Functional/LoadTest.php                                                                                                                   
 ------ ------------------------------------------------------
  13     Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to  
         use.                                                                                                                                                
  32     Return type mixed of method Drupal\Tests\eu_cookie_compliance_gtm\Functional\LoadTest::setUp() is not covariant with return type void of method     
         PHPUnit\Framework\TestCase::setUp().                                                                                                                
 ------ ---------------------------------------------

Automated Review

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

Note that perfect adherence to Drupal Coding Standard → is a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

I have fixed the PHPCS, PHPstan and licensing issues mentioned above in branch 2.x

regarding the PHPstan error about the invalid type CookieCategory: I guess that is a false-positve when not tested in proper context
however, I did rename the variable from $menu to $category which is more relevant

As a side note, Application checklist → has a point about license files.

Ensure the top directory of the repository does not contain a LICENSE.txt (or similar) file

Do not include a LICENSE.txt file in the top directory of your repository. Drupal.org will add the appropriate version automatically during packaging.

It is incorrect to say a license file must be present. Projects hosted on drupal.org are not allowed to be licensed under a license that is different from the one used by Drupal. That would be possible, eventually, for projects containing only assets file.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Automatically closed - issue fixed for 2 weeks with no activity.