This approach works well. We have recently started using the Recurring Events module, which creates a custom entity type for all events. We want to add a print option to all event pages. I was able to select the custom entity and configure it to enable printing on event pages.
Patch #7 worked for me as well. (Durpal 10.4, module verison 8.x-1.21)
I have applied the #7 patch and still see more errors:
FILE: ../docroot/modules/contrib/pathauto/tests/src/FunctionalJavascript/PathautoLocaleTest.php
31 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines
65 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
83 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
87 | ERROR | The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
and
FILE:./docroot/modules/contrib/pathauto/tests/src/Functional/PathautoSettingsFormWebTest.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
224 | ERROR | Type hint "array" missing for $settings
-----------------------------------------------------------
Looks good! The Gitlab-ci.yml file added and pipeline is running.
I also think you need to use tokens to generate unique URLs. Click the "Browse available tokens" link in the configuration page to view the tokens. This will help you identify the most suitable token for the term.
After updating the pattern to include a token, save the configuration and regenerate the paths if needed.
For example:
/board/term/[term:name]: This will include the term name in the URL.
/board/term/[term:tid]: This will use the term's unique ID.
I am using drupal 10.3.10, php version 8.3. I am unable to install this module using the patch.
- Root composer.json requires drupal/taxonomy_breadcrumb ^1.1 -> satisfiable by drupal/taxonomy_breadcrumb[1.1.0].
- drupal/taxonomy_breadcrumb 1.1.0 requires drupal/core ^8 -> found drupal/core[8.0.0, ..., 8.9.20] but these were not loaded, likely because it conflicts with another require
I am on Drupal 10.3 site and exploring some options, but I couldn't apply the patch #8 or #14. Below is the error I encountered with this module 3.0 version:
PHP Fatal error: Type of Drupal\groupmenu\Controller\GroupMenuController::$privateTempStoreFactory must not be defined (as in class Drupal\group\Entity\Controller\GroupRelationshipController) in /var/www/html/docroot/modules/contrib/groupmenu/src/Controller/GroupMenuController.php on line 17
@pene I just recently updated this module to 1.11 and didn't see this error. I'm on drupal 10.3 and php version 8.2.22
+1 confirmed phpcs errors are now fixed.
MR! 80 works great with 4.0 and drupal 10.3. Thanks!
I have tested the #9 patch, and can confirm that it works well. Thanks!
We are using Gin Admin theme, and can confirm this works great!
Tested patch #30, works great! - Drupal 10.3.10, and gin_login 2.1
I also didn't get the error with this module. I am on drupal version 10.3.10 and PHP version 8.3.10
smustgrave → credited pilot3 → .
hi @prem suthar, I updated the module to 1.25, and tried to apply the patch with your new commit. The patch can't apply.
I am having the same issue on our site. Did you find a solution?
pilot3 → created an issue.
I have updated this module to the latest released version 3.6 with core 10.3. I do not see this issue. Looks like it has been fixed.
MR!39 update looks great and follows the README Template Standard.
I installed the 2.1.x-dev version and tested it on Drupal 10.3 with patch #15. It works great. I can add responsive plugin buttons to text formatting and CKEditor5 loads fine.
pilot3 → created an issue.
I've also tested MR 29 with Drupal 10.3.0 and can confirm it displays the helper text correctly, and validates correctly and enables svg images to be uploaded.
I can confirm that Cspell is passed through the pipeline and the code looks good.
I want to review this, but I don't see the same problem on my site. I use Gin as admin theme and had field group module set horizontal.
It worked for me. Thanks!
pilot3 → created an issue.
Reviewed and verified that tests are passing in the pipeline.
I have reviewed that the gitlab-ci.yml file has been added to the repo and pipelines are working.
pilot3 → created an issue.
pilot3 → created an issue.
I have reviewed that the gitlab-ci.yml file has been added to the repo and pipelines are working.
pilot3 → created an issue.
I have reviewed that the gitlab-ci.yml file has been added to the repo.
pilot3 → created an issue.
pilot3 → created an issue.
Looks great! The eslint tests now pass on the pipeline.
Looks good! The pipelines job is passing eslint test.
pilot3 → created an issue.
pilot3 → created an issue.
Looks good! Now the test is passing phpstan error in gitlab ci.
pilot3 → created an issue.
Reviewed and confirmed that .gitlab-ci.yml file was added and tests are running. There are some eslint, phpcs and phpstan warnings that can be addressed in another issue.
pilot3 → created an issue.
pilot3 → created an issue.
pilot3 → created an issue.
pilot3 → created an issue.
pilot3 → created an issue.
Add the .gitlab-ci.yml file to the module for gitlab to run automated tests. source- https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →
pilot3 → made their first commit to this issue’s fork.
+1 for DDEV. Its user-friendliness, simplicity, and stability enhance the experience for beginners in Drupal development. DDEV makes it very easy for new Drupal developers to focus more on their Drupal skills rather than struggling with complex development environments.
@Anybody, Thank you for your patience and guidance! @thakurnishant_06 Thanks for taking the initiative and showing how it should be done. I made minor changes based on your input.
One more screenshot
@Anybody Please ignore the 2.0.x branch README.md changes. MR 13 has the latest changes.
Here are some screenshots of the view link area module configuration steps.
Also here are recommendations for module description :
Module description:
1. First paragraph change to
The Views Link Area module provides a "link" plugin for Views. It allows customized links to be placed in the header, footer, or empty text of any view.
2. Change module title to capitalize all first letters - Views Link Area
I am in the process of upgrading this to CKEditor5. I applied both MR !4 and MR !2 patches on my local (php8.1, drupal 9.5.7). It seems like not working for me. I couldn't see the button icon show up on the wysiwyg area on CKEditor 5. I am using Upgrade_status module. Anyone has the same issue?
@shelane Thank you for working on this module! Do you have a plan when to release the new D10-compatible version that supports CKEditor 5?
Hi @Anybody, I am new to drupal contribution. Sorry, I forgot to follow up on this issue that I opened early this year. It looks like the description of this module has been updated since last time. It's concise and great! I was originally going to add the screenshots above somewhere in the configuration area, but I couldn't find where to add them. I think you can close this issue now if you want to.
I am in the process of upgrading this to CKEditor5. I noticed that If I use the version to `^2.1.x-dev` with #13 patch. The patch applied. But #13 patch doesn't contain D10 computability changes. If I keep `^2.0` version, the patch won't apply.
@sarwan I tried to apply the patch on the 3.0.x branch, It couldn't apply.
Upgrade from ^3.0 to ^3.1 version, I had same warning messages. I applied the 3381366-5.patch, and confirm that the warning messages went away. Thanks!
pilot3 → made their first commit to this issue’s fork.
Verified it is a misspelling of the word, good catch!
I installed and followed the steps to test this module on my local. It seems working well. If I config the Markdown Easy filter below the "Limit allowed HTML tags and correct faulty HTML" and "Convert line breaks into HTML" filters. I will get Warning message which is super helpful.
This migrate_tools_2863426.patch doesn't apply anymore when I upgrade to 6.0 version for D10 compatibly. I updated the patch for version 6.0
@ultimike - You are welcome! Thanks for putting your time and effort into this!
As for Chinese, It is better to trim with character, not words. A word can be combined with multiple Chinese Characters, and It is hard to separate words when we use them without understanding the whole sentence. The meaning can be totally different.
For instance-when there is a requirement to write an 800 words article, It is counted as per Chinese character.
@lostcarpark-- There are many two-character words, and four-character words(phrases) in Chinese. Sometimes two words have similar meanings to use it formally, sometimes two words have completely different meanings, but to support each other to have a new meaning. It is hard to understand sentences with single character words . Not really sure a good way to split a word in a sentence. I think it make sense to split it by punctuation in a paragraph. Hope this will help.
@ultimike -- Yes. Those are Chinese - Hanzi, ( Mandarin and Cantonese are almost same with written style, It's based on characters rather than the alphabet letter.)
A Chinese character can be a word, or multiple Chinese characters can combine into a word. In this case for testing, I think each Chinese character can consider a word for statistics.
I tested with a paragraph of Chinese, It seems only work when I set 'Trim units' to Characters, not "Words". Here are some test results:
Test example: 兔子吹嘘自己跑得有多快。 他在嘲笑乌龟这么慢。 令兔子大吃一惊的是,乌龟向他发起了一场比赛。 兔子觉得这是个好笑话,就接受了挑战。 狐狸是比赛的裁判。 比赛开始时,兔子跑在乌龟前面,正如大家所想的那样.
1. Trimmed to 50 characters, it should stops at here-- 兔子吹嘘自己跑得有多快。 他在嘲笑乌龟这么慢。 令兔子大吃一惊的是,乌龟向他发起了一场比赛。 兔子觉得这是个好笑话, but maybe it counts punctuation as a character, it stops at the closest end of a sentence before 50 characters at here 兔子吹嘘自己跑得有多快。 他在嘲笑乌龟这么慢。 令兔子大吃一惊的是,乌龟向他发起了一场比赛。
2. Trimmed to 7 words, It should stop at here --兔子吹嘘自己跑, but it displayed the whole paragraph. Not working with words!
3. Trimmed to 7 characters, It should stop at here --兔子吹嘘自己跑, It did.
4. Trimmed to the end of the sentence following the first 7 character -- Add Suffix "想的那样", it should look like this " 兔子吹嘘自己跑想的那样". It did.