- Issue created by @pilot3
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 111 pass, 2 fail - 🇺🇸United States DamienMcKenna NH, USA
The original MR was created from the 2.0.x and against the 8.x-1.x branch, so I edited it to go against the 2.0.x branch. The tests are running again, we'll see how it goes.
- Status changed to Needs review
about 1 year ago 4:53pm 28 November 2023 - Status changed to Needs work
about 1 year ago 3:06pm 30 November 2023 - 🇷🇺Russia zniki.ru
Failed tests aren't dangerous and can be fixed in follow up task.
phpunit jobs takes 11 minutes because contrib by default runs them not parallel. Lets use concurrency/run-tests.sh, see https://git.drupalcode.org/project/flag/-/merge_requests/58/diffsAdding phpstan.neon file and ignore phpstan "Unsafe usage of new static()." error, is also good idea.
- last update
12 months ago 50 pass, 27 fail - last update
12 months ago 50 pass, 27 fail - 🇷🇺Russia zniki.ru
I create separate issue to fix PHPunit tests 📌 Adapt tests for Drupal 10.2 Needs work
- last update
10 months ago 110 pass - last update
10 months ago 110 pass - Status changed to Needs review
10 months ago 10:09am 20 February 2024 - Status changed to RTBC
10 months ago 3:39pm 20 February 2024 - 🇷🇺Russia zniki.ru
DamienMcKenna, thanks for fixing tests.
Changes in the MR looks good.
I am not sure about changes in method MetatagTagTypesTest::todoTestUrl(), but I leave it up to you.
I would completely remove this method.Mark this as RTBC.
- last update
10 months ago 110 pass -
DamienMcKenna →
committed ea84eb8a on 2.0.x authored by
pilot3 →
Issue #3404463 by pilot3, DamienMcKenna, Nikolay Shapovalov,...
-
DamienMcKenna →
committed ea84eb8a on 2.0.x authored by
pilot3 →
- Status changed to Fixed
10 months ago 11:10am 23 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.